bazel: Update googleurl by keith · Pull Request #18249 · envoyproxy/envoy

keith · 2021-09-24T00:53:07Z

This was reverted previously due to an issue with older android NDK versions, the last commit works around that issue until bazel supports newer versions.

Signed-off-by: Keith Smiley keithbsmiley@gmail.com

repokitteh-read-only · 2021-09-24T00:53:11Z

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #18249 was opened by keith.

see: more, trace.

keith · 2021-09-24T00:54:16Z

@mattklein123 @wrowe @buildbreaker this is the Android only part of the fix (targeting Matt's revert branch) I think with this we should be unblocked to land these

buildbreaker

Yep! This was what I was going for

keith · 2021-09-24T00:58:19Z

Testing on envoy-mobile CI envoyproxy/envoy-mobile#1830

mattklein123

Awesome, thanks a ton for tracking this down.

I closed my other PR so can you just bump the dep at the same time and we can review/merge it all at once?

/wait

bazel/external/googleurl.patch

buildbreaker · 2021-09-24T02:12:44Z

@mattklein123 This PR was intended to merge into your PR 😬

The base branch was changed.

mattklein123

Awesome, thanks!

bazel/repository_locations.bzl

moderation · 2021-09-27T13:27:55Z

Hhhmmm. The error is the incorrect date for rules_go

github_release:  GitHubRelease(organization='bazelbuild', project='rules_go', version='v0.27.0', tagged=True)
*WARNING* io_bazel_rules_go has a newer release than v0.27.0@<2021-03-18 15:02:42>: v0.28.0@<2021-07-06 23:21:45>
io_bazel_rules_go has a GitHub release date 2021-03-18
An error occurred while processing ./bazel/repository_locations.bzl, please verify the correctness of the metadata: Mismatch with metadata release date of 2021-03-17

…nvoyproxy#17958)" This reverts commit 338a42c. Signed-off-by: Matt Klein <mklein@lyft.com>

Signed-off-by: Matt Klein <mklein@lyft.com>

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>

mattklein123

Thanks!

keith · 2021-09-30T00:22:53Z

/retest

repokitteh-read-only · 2021-09-30T00:22:56Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18249 (comment) was created by @keith.

see: more, trace.

mattklein123 · 2021-09-30T04:15:10Z

Coverage seems like a flake to me.

mattklein123 · 2021-09-30T04:15:17Z

/retest

repokitteh-read-only · 2021-09-30T04:15:21Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18249 (comment) was created by @mattklein123.

see: more, trace.

mattklein123 · 2021-09-30T13:25:18Z

Somehow line coverage for lua seems to be persistently failing on this PR which I really don't understand. Can you take a quick look at the line diffs from coverage to see if anything pops up? You can see the coverage report in CI and here is the main report: https://storage.googleapis.com/envoy-postsubmit/main/coverage/index.html. cc @lizan for any ideas on this.

keith · 2021-09-30T21:44:34Z

I imagine the tests have some async behavior that causes this to be hit or not, doesn't appear related to this change

mattklein123 · 2021-09-30T21:45:48Z

Yup OK I'm fine force merging. We can sort out coverage on main. Thank you!

repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Sep 24, 2021

buildbreaker previously approved these changes Sep 24, 2021

View reviewed changes

mattklein123 self-assigned this Sep 24, 2021

mattklein123 mentioned this pull request Sep 24, 2021

Revert "Revert "bazel: update DEPS on googleurl (#17794)" (#17958)" #18167

Closed

mattklein123 requested changes Sep 24, 2021

View reviewed changes

bazel/external/googleurl.patch Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Sep 24, 2021

keith changed the base branch from gurl_update to main September 24, 2021 02:43

keith changed the title ~~bazel: Fix googleurl on Android~~ bazel: Update googleurl Sep 24, 2021

keith force-pushed the with-android branch from 47b1908 to 4cf397a Compare September 24, 2021 02:44

repokitteh-read-only bot removed the waiting label Sep 24, 2021

keith requested a review from mattklein123 September 24, 2021 02:44

mattklein123 previously approved these changes Sep 24, 2021

View reviewed changes

dio reviewed Sep 24, 2021

View reviewed changes

bazel/repository_locations.bzl Outdated Show resolved Hide resolved

keith dismissed mattklein123’s stale review via 8272cbc September 24, 2021 03:39

mattklein123 added the waiting label Sep 24, 2021

keith force-pushed the with-android branch from 8272cbc to 245734b Compare September 24, 2021 19:59

repokitteh-read-only bot removed the waiting label Sep 24, 2021

moderation reviewed Sep 25, 2021

View reviewed changes

bazel/repository_locations.bzl Outdated Show resolved Hide resolved

mattklein123 added the waiting label Sep 26, 2021

mattklein123 and others added 5 commits September 29, 2021 11:46

Revert "Revert "bazel: update DEPS on googleurl (envoyproxy#17794)" (e…

379ce3f

…nvoyproxy#17958)" This reverts commit 338a42c. Signed-off-by: Matt Klein <mklein@lyft.com>

fix

2ae623c

Signed-off-by: Matt Klein <mklein@lyft.com>

bazel: Fix googleurl on Android

9f116ec

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>

Update locations

070c016

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>

Update date

383f99d

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>

keith force-pushed the with-android branch from f8c1965 to 383f99d Compare September 29, 2021 18:46

repokitteh-read-only bot removed the waiting label Sep 29, 2021

mattklein123 approved these changes Sep 29, 2021

View reviewed changes

mattklein123 approved these changes Sep 30, 2021

View reviewed changes

mattklein123 merged commit e9ee985 into envoyproxy:main Sep 30, 2021

keith deleted the with-android branch September 30, 2021 21:48

junr03 mentioned this pull request Sep 30, 2021

envoy: e9ee98576 envoyproxy/envoy-mobile#1849

Merged

Conversation

keith commented Sep 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only bot commented Sep 24, 2021

Uh oh!

keith commented Sep 24, 2021

Uh oh!

buildbreaker left a comment

Choose a reason for hiding this comment

Uh oh!

keith commented Sep 24, 2021

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

buildbreaker commented Sep 24, 2021

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

moderation commented Sep 27, 2021

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

keith commented Sep 30, 2021

Uh oh!

repokitteh-read-only bot commented Sep 30, 2021

Uh oh!

mattklein123 commented Sep 30, 2021

Uh oh!

mattklein123 commented Sep 30, 2021

Uh oh!

repokitteh-read-only bot commented Sep 30, 2021

Uh oh!

mattklein123 commented Sep 30, 2021

Uh oh!

keith commented Sep 30, 2021

Uh oh!

mattklein123 commented Sep 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

keith commented Sep 24, 2021 •

edited

Loading