Revert "bazel: update rules_foreign_cc (#17445)"#17780
Merged
Conversation
This reverts commit 5e48a19. Signed-off-by: Jose Nino <jnino@lyft.com>
repokitteh-read-only
bot
added
the
deps
keith
previously approved these changes
Aug 19, 2021
Member
Author
|
discussed with @keith. He is going to work on a fix on rules_foreign_cc upstream to allow us to actually update. |
snowp
previously approved these changes
Aug 19, 2021
Member
Author
|
thanks @snowp! |
Signed-off-by: Jose Nino <jnino@lyft.com>
Member
Author
|
For posterity: bazel-contrib/rules_foreign_cc#767 |
snowp
approved these changes
Aug 19, 2021
Contributor
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
keith
added a commit
to keith/envoy
that referenced
this pull request
Aug 21, 2021
…nvoyproxy#17780)" This reverts commit 26dae5d. This issue was fixed by bazel-contrib/rules_foreign_cc@da8952e Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
htuch
pushed a commit
that referenced
this pull request
Aug 26, 2021
…17799) This reverts commit 26dae5d. This issue was fixed by bazel-contrib/rules_foreign_cc@da8952e Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
keith
added a commit
to keith/envoy
that referenced
this pull request
Aug 27, 2021
)" (envoyproxy#17780)" (envoyproxy#17799)" This reverts commit 4b3f4a5. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
mattklein123
pushed a commit
that referenced
this pull request
Aug 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 5e48a19.
The update breaks the ability to compile from a MacOS host for an iOS device. For example the sysroot choice here is broken. @keith is working on a fix, but for the time being we can revert to unblock consumers e.g., Envoy Mobile.
Signed-off-by: Jose Nino jnino@lyft.com