bazel: update rules_foreign_cc#17799
Merged
htuch merged 1 commit intoenvoyproxy:mainfrom Aug 26, 2021
Merged
Conversation
…nvoyproxy#17780)" This reverts commit 26dae5d. This issue was fixed by bazel-contrib/rules_foreign_cc@da8952e Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
repokitteh-read-only
bot
added
the
deps
keith
changed the title
Contributor
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
moderation
approved these changes
Aug 23, 2021
htuch
reviewed
Aug 25, 2021
| release_date = "2020-10-26", | ||
| use_category = ["build"], | ||
| release_date = "2021-08-21", | ||
| use_category = ["build", "dataplane_core", "controlplane"], |
Member
There was a problem hiding this comment.
Is this actually required by the dependency checker? LGTM otherwise.
Member
Author
There was a problem hiding this comment.
yea, we probably need to investigate out of band, it seems the toolchains changes made in this repo make it so there's a connection from these where I'm surprised to see it. This also avoided it #17598 but it's a bit riskier, so this seemed fine for now
keith
deleted the
ks/revert-revert-bazel-update-rules_foreign_cc-17445-17780
branch
keith
added a commit
to keith/envoy
that referenced
this pull request
Aug 27, 2021
)" (envoyproxy#17780)" (envoyproxy#17799)" This reverts commit 4b3f4a5. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
mattklein123
pushed a commit
that referenced
this pull request
Aug 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 26dae5d.
This issue was fixed by bazel-contrib/rules_foreign_cc@da8952e
Signed-off-by: Keith Smiley keithbsmiley@gmail.com