Merged
Conversation
Signed-off-by: Jose Nino <jnino@lyft.com>
Augustyniak
previously approved these changes
Aug 20, 2021
buildbreaker
previously approved these changes
Aug 20, 2021
added 2 commits
August 20, 2021 09:51
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Member
Author
|
Going to merge regardless because the failure on the new commit is CI failure and the change does not affect any of the jobs that passed in the previous commit. The only job that mattered is the python tests one and that is passing now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
includes: envoyproxy/envoy#17775 and envoyproxy/envoy#17780
Signed-off-by: Jose Nino jnino@lyft.com