Increase buffer size of Win32RedirectRecords#17471
Merged
wrowe merged 1 commit intoenvoyproxy:mainfrom Jul 27, 2021
Merged
Conversation
While testing the feature I noticed that we can not retrieve the
redirect records for the following curl request:
`curl.exe -s -o NUL -D - -I -w StatusCode:%{http_code} -L http://edition.cnn.com`
Increase the buffer size to 2kb to resolve the issue.
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Member
Author
|
@wrowe do you want to review this one? |
Member
Author
|
cc @envoyproxy/windows-dev |
baojr
added a commit
to baojr/envoy
that referenced
this pull request
Jul 29, 2021
…bridge-stream * upstream/main: (140 commits) quiche: remove google quic support (envoyproxy#17465) runtime: removing envoy.reloadable_features.check_ocsp_policy (envoyproxy#17524) upstream: not trying to do HTTP/3 where not configured (envoyproxy#17454) api: Remove confusing line about auto-generation (envoyproxy#17536) v2: removing bootstrap (envoyproxy#17523) connpool: Fix crash in pool removal if the cluster was already deleted (envoyproxy#17522) Enhance the comments clearly (envoyproxy#17517) mysql proxy: connection attributes parsing (envoyproxy#17209) [ci] fix false positive CVE scan from node (envoyproxy#17510) Fixing Envoy Mobile factory strings (envoyproxy#17509) http3: validating codec (envoyproxy#17452) quic: add QUIC upstream stream reset error stats (envoyproxy#17496) thrift proxy: move UpstreamRequest into its own file (envoyproxy#17498) docs: Fixed FaultDelay docs. (envoyproxy#17495) updates links to jaegertracing-plugin.tar.gz (envoyproxy#17497) http: make custom inline headers bootstrap configurable (envoyproxy#17330) deps: update yaml-cpp to latest master (envoyproxy#17489) improving tracer coverage (envoyproxy#17493) Increase buffer size of `Win32RedirectRecords` (envoyproxy#17471) ext_proc: Fix problem with buffered body mode with empty or no body (envoyproxy#17430) ... Signed-off-by: Garrett Bourg <bourg@squareup.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
While testing the feature I noticed that we can not retrieve the
redirect records for the following curl request:
`curl.exe -s -o NUL -D - -I -w StatusCode:%{http_code} -L http://edition.cnn.com`
Increase the buffer size to 2kb to resolve the issue.
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
While testing the feature I noticed that we can not retrieve the
redirect records for the following curl request:
curl.exe -s -o NUL -D - -I -w StatusCode:%{http_code} -L http://edition.cnn.comIncrease the buffer size to 2kb to resolve the issue.
Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com
Additional Description:
Risk Level: Low
Testing: Manually tested with the repro
Docs Changes: N/A
Release Notes: This feature is still in alpha so I do not think we need it
Platform Specific Features: Windows only