Skip to content

docs: Use bazel build for generating external deps rst#16767

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:docs-external-deps
Jun 3, 2021
Merged

docs: Use bazel build for generating external deps rst#16767
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:docs-external-deps

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Jun 2, 2021

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: docs: Use bazel build for generating external deps rst
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax force-pushed the docs-external-deps branch 2 times, most recently from 7399234 to 7caaf1a Compare June 2, 2021 09:47
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the docs-external-deps branch from 7caaf1a to 95e572d Compare June 2, 2021 10:36
@phlax phlax marked this pull request as ready for review June 2, 2021 11:55
@phlax phlax requested a review from mattklein123 June 2, 2021 11:55
@phlax phlax changed the title [WIP] docs: Use bazel build for generating external deps rst docs: Use bazel build for generating external deps rst Jun 2, 2021
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phlax phlax merged commit b431c70 into envoyproxy:main Jun 3, 2021
@PiotrSikora
Copy link
Copy Markdown
Contributor

I beleive this broke precheck dependencies:

Traceback (most recent call last):
  File "/source/tools/dependency/release_dates.py", line 20, in <module>
    import utils
  File "/source/tools/dependency/utils.py", line 5, in <module>
    from tools.dependency.exports import (
ModuleNotFoundError: No module named 'tools'

(from: #16430 -> https://dev.azure.com/cncf/envoy/_build/results?buildId=77650&view=logs&jobId=02101c82-0ad6-591f-f821-6c2adfa0913c&j=02101c82-0ad6-591f-f821-6c2adfa0913c&t=2eacb0d3-1406-5ed1-12df-130fbd8dccf7)

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jun 3, 2021

thanks @PiotrSikora ill check now...

leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants