Skip to content

dependencies: Fix script imports#16798

Merged
yanavlasov merged 1 commit intoenvoyproxy:mainfrom
phlax:release-dates
Jun 3, 2021
Merged

dependencies: Fix script imports#16798
yanavlasov merged 1 commit intoenvoyproxy:mainfrom
phlax:release-dates

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Jun 3, 2021

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: dependencies: Fix script imports
Additional Description:

#16767 broke the release dates script despite passing CI - this should fix the problem for now

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #16798 was opened by phlax.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jun 3, 2021
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jun 3, 2021

cc @PiotrSikora

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title [WIP/TESTING] dependencies: Fix script imports dependencies: Fix script imports Jun 3, 2021
@phlax phlax marked this pull request as ready for review June 3, 2021 10:13
@phlax phlax requested a review from PiotrSikora June 3, 2021 10:14
@phlax phlax removed the deps Approval required for changes to Envoy's external dependencies label Jun 3, 2021
@yanavlasov yanavlasov merged commit bf3c19c into envoyproxy:main Jun 3, 2021
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants