Skip to content

wasm: update Proxy-Wasm C++ Host to latest (2021-06-01).#16430

Merged
mattklein123 merged 24 commits intoenvoyproxy:mainfrom
PiotrSikora:wasm-bytecode
Jun 8, 2021
Merged

wasm: update Proxy-Wasm C++ Host to latest (2021-06-01).#16430
mattklein123 merged 24 commits intoenvoyproxy:mainfrom
PiotrSikora:wasm-bytecode

Conversation

@PiotrSikora
Copy link
Copy Markdown
Contributor

@PiotrSikora PiotrSikora commented May 11, 2021

Signed-off-by: Piotr Sikora piotrsikora@google.com

@PiotrSikora
wasm: update Proxy-Wasm C++ Host to latest (2021-05-11).
3a28d51 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented May 11, 2021

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #16430 was opened by PiotrSikora.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label May 11, 2021
@PiotrSikora
review: pass stripped bytecode and precompiled module.
c838b2a 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora
Merge remote-tracking branch 'origin/main' into PiotrSikora/wasm-byte…
a07fff8 
…code
@PiotrSikora
review: fix format.
7258f94 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora
review: bump commit.
77323eb 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora
review: Kick CI.
af4d395 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora
review: fix format.
2dfe090 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora
review: update commit.
f8d0400 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora
review: fix test on Linux-aarch64.
8558079 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora
review: fix test on Linux-aarch64 (take 2).
b5963b6 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora PiotrSikora changed the title wasm: update Proxy-Wasm C++ Host to latest (2021-05-11). wasm: update Proxy-Wasm C++ Host to latest (2021-05-15). May 15, 2021
@PiotrSikora PiotrSikora marked this pull request as ready for review May 17, 2021 00:51
@PiotrSikora PiotrSikora requested a review from lizan as a code owner May 17, 2021 00:51
@PiotrSikora PiotrSikora changed the title wasm: update Proxy-Wasm C++ Host to latest (2021-05-15). wasm: update Proxy-Wasm C++ Host to latest (2021-05-16). May 17, 2021
mathetake
mathetake previously approved these changes May 17, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@moderation
Copy link
Copy Markdown
Contributor

moderation commented May 17, 2021

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label May 17, 2021
@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label May 28, 2021
@PiotrSikora PiotrSikora mentioned this pull request May 28, 2021
Merged
mathetake
mathetake previously approved these changes May 30, 2021
View reviewed changes
@mathetake
Copy link
Copy Markdown
Member

mathetake commented Jun 3, 2021

@PiotrSikora could you resolve conflict? This now is a blocker for #16795

@PiotrSikora
Merge remote-tracking branch 'origin/main' into PiotrSikora/wasm-byte…
0f1b23c 
…code

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@mathetake mathetake mentioned this pull request Jun 3, 2021
Merged
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jun 3, 2021
@PiotrSikora
Copy link
Copy Markdown
Contributor Author

PiotrSikora commented Jun 3, 2021

/retest

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Jun 3, 2021

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16430 (comment) was created by @PiotrSikora.

see: more, trace.

@PiotrSikora PiotrSikora mentioned this pull request Jun 3, 2021
Merged
@phlax
Copy link
Copy Markdown
Member

phlax commented Jun 3, 2021 •
edited
Loading

@PiotrSikora its passing in postsubmit - and was passing in the presubmit checks

i dont think the failure is change-related (i might be wrong) - would merging main fix ?

@phlax
Copy link
Copy Markdown
Member

phlax commented Jun 3, 2021

... actually - it is change-related - and i think you are right it broke this script - ill work on a fix now...

@PiotrSikora
Copy link
Copy Markdown
Contributor Author

PiotrSikora commented Jun 3, 2021

@PiotrSikora its passing in postsubmit - and was passing in the presubmit checks

I've noticed, but perhaps the old results are cached and/or the broken code is not executed if dependencies (e.g. bazel/repository_locations.bzl) didn't change?

i dont think the failure is change-related (i might be wrong) - would merging main fix ?

Merging main branch (up to #16767) is the reason for this failure, it passed tests before.

@phlax
Copy link
Copy Markdown
Member

phlax commented Jun 3, 2021

yep - the longer term fix for this is:

  • the failing job is moved to bazel
  • proper tests are added

its failed a few times before after a passing PR was landed

@PiotrSikora
Merge remote-tracking branch 'origin/main' into PiotrSikora/wasm-byte…
b22ef87 
…code

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora
review: update to the most recent commit.
ba48b89 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora PiotrSikora changed the title wasm: update Proxy-Wasm C++ Host to latest (2021-05-28). wasm: update Proxy-Wasm C++ Host to latest (2021-06-01). Jun 3, 2021
@PiotrSikora
Copy link
Copy Markdown
Contributor Author

PiotrSikora commented Jun 3, 2021

/retest

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Jun 3, 2021

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16430 (comment) was created by @PiotrSikora.

see: more, trace.

@PiotrSikora
Copy link
Copy Markdown
Contributor Author

PiotrSikora commented Jun 3, 2021

Windows CI is broken on main, and Wasm is disabled there anyway.

@mathetake
Copy link
Copy Markdown
Member

mathetake commented Jun 7, 2021

kindly ping @moderation for dep

@moderation
Copy link
Copy Markdown
Contributor

moderation commented Jun 7, 2021

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Jun 7, 2021
@mathetake
Copy link
Copy Markdown
Member

mathetake commented Jun 7, 2021

@lizan can we merge now?

@mattklein123 mattklein123 merged commit 4705ada into envoyproxy:main Jun 8, 2021
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
@PiotrSikora
wasm: update Proxy-Wasm C++ Host to latest (2021-06-01). (envoyproxy#…
4d4b816 
…16430)

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

@mathetake mathetake mathetake left review comments

@lizan lizan Awaiting requested review from lizan

+1 more reviewer

@moderation moderation moderation left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@lizan lizan

@mathetake mathetake

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@PiotrSikora @moderation @mathetake @phlax @mattklein123 @lizan