[1.18] apple dns: fix crash on invalid dns name (#16028)#16662
Merged
mattklein123 merged 2 commits intoenvoyproxy:release/v1.18from Jun 4, 2021
dmitri-d:1.18-fix-crash-apple-dns
Merged
[1.18] apple dns: fix crash on invalid dns name (#16028)#16662mattklein123 merged 2 commits intoenvoyproxy:release/v1.18from dmitri-d:1.18-fix-crash-apple-dns
mattklein123 merged 2 commits intoenvoyproxy:release/v1.18from
dmitri-d:1.18-fix-crash-apple-dns
Conversation
Member
|
This diff can still crash. This is the final patch: #16369 |
Commit Message: apple dns - fix interface issue with localhost lookup Additional Description: deleting ENVOY_BUG statement, as localhost dns resolution renders a valid non-zero interface index. Risk Level: low Testing: fixed previously existing test that did not have a run block. Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: Dmitri Dolguikh <ddolguik@redhat.com>
Contributor
Author
Member
|
@dmitri-d missing the assert deletion: envoy/source/common/network/apple_dns_impl.cc Line 305 in b0cdfcb |
Signed-off-by: Dmitri Dolguikh <ddolguik@redhat.com>
junr03
approved these changes
Jun 1, 2021
Member
|
@envoyproxy/security-team can someone with permissions merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #16028