Conversation
added 2 commits
April 15, 2021 21:26
Signed-off-by: Jose Nino <jnino@lyft.com>
htuch
suggested changes
Apr 18, 2021
| // This callback should never be executed. | ||
| FAIL(); | ||
| })); | ||
|
|
| return; | ||
| } | ||
|
|
||
| RELEASE_ASSERT(interface_index == 0, |
Member
There was a problem hiding this comment.
Should this be ENVOY_BUG? I.e. it's fully recoverable.
added 2 commits
April 20, 2021 12:36
added 2 commits
April 21, 2021 14:10
Member
Author
|
@htuch this is ready. |
|
Hi - will this make it into a patch for |
Member
Author
|
No, we only have security patches with designated CVEs. This will make it into the next point release: 1.19 |
|
It looks like this should qualify for backporting https://github.com/envoyproxy/envoy/blob/main/RELEASES.md#stable-releases
Justification:
|
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
The release assert in question was ahead of verifying the return code. Risk Level: low - most (possibly all) envoy production usage does not happen on apple hardware. Testing: added new test that repro. Fixes envoyproxy#16021 Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: Gokul Nair <gnair@twitter.com>
|
/backport |
repokitteh-read-only
bot
added
the
backport/review
|
/cc @PiotrSikora can I get this reviewed for backport to maintained releases? I believe 1.17+. |
Member
|
cc @dmitri-d |
This was referenced May 25, 2021
mattklein123
pushed a commit
that referenced
this pull request
Jun 4, 2021
Commit Message: apple dns - fix interface issue with localhost lookup Additional Description: deleting ENVOY_BUG statement, as localhost dns resolution renders a valid non-zero interface index. Risk Level: low Testing: fixed previously existing test that did not have a run block. Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: Dmitri Dolguikh <ddolguik@redhat.com>
alyssawilk
added
backport/approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: apple dns: fix crash on invalid dns name.
Additional Description: The release assert in question was ahead of verifying the return code.
Risk Level: low - most (possibly all) envoy production usage does not happen on apple hardware.
Testing: added new test that repro.
Fixes #16021
Signed-off-by: Jose Nino jnino@lyft.com