apple dns: fix interface issue with localhost lookup#16369
Merged
junr03 merged 2 commits intoenvoyproxy:mainfrom May 7, 2021
junr03:localhost-dns
Merged
apple dns: fix interface issue with localhost lookup#16369junr03 merged 2 commits intoenvoyproxy:mainfrom junr03:localhost-dns
junr03 merged 2 commits intoenvoyproxy:mainfrom
junr03:localhost-dns
Conversation
Signed-off-by: Jose Nino <jnino@lyft.com>
htuch
previously approved these changes
May 7, 2021
Signed-off-by: Jose Nino <jnino@lyft.com>
Member
Author
|
@htuch, I failed to push all my commits. Do you mind reviewing again? Thanks! |
htuch
approved these changes
May 7, 2021
This was referenced May 26, 2021
alyssawilk
pushed a commit
that referenced
this pull request
Jun 3, 2021
…#16663) Commit Message: apple dns - fix interface issue with localhost lookup Additional Description: deleting ENVOY_BUG statement, as localhost dns resolution renders a valid non-zero interface index. Risk Level: low Testing: fixed previously existing test that did not have a run block. Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: Dmitri Dolguikh <ddolguik@redhat.com> Co-authored-by: Jose Ulises Nino Rivera <junr03@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: apple dns - fix interface issue with localhost lookup
Additional Description: deleting ENVOY_BUG statement, as localhost dns resolution renders a valid non-zero interface index.
Risk Level: low
Testing: fixed previously existing test that did not have a run block.
Signed-off-by: Jose Nino jnino@lyft.com