Skip to content

wasm: add gRPC tests written using Proxy-Wasm Rust SDK.#16722

Merged
mattklein123 merged 11 commits intoenvoyproxy:mainfrom
PiotrSikora:wasm-rust_grpc
Jul 9, 2021
Merged

wasm: add gRPC tests written using Proxy-Wasm Rust SDK.#16722
mattklein123 merged 11 commits intoenvoyproxy:mainfrom
PiotrSikora:wasm-rust_grpc

Conversation

@PiotrSikora
Copy link
Copy Markdown
Contributor

Fixes #16432.

Signed-off-by: Piotr Sikora piotrsikora@google.com

Fixes envoyproxy#16432.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label May 28, 2021
@PiotrSikora PiotrSikora requested a review from Shikugawa May 28, 2021 20:19
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #16722 was opened by PiotrSikora.

see: more, trace.

@PiotrSikora PiotrSikora requested a review from mathetake May 28, 2021 20:19
@PiotrSikora
Copy link
Copy Markdown
Contributor Author

(Blocked on #16430)

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora PiotrSikora marked this pull request as ready for review July 1, 2021 22:18
@PiotrSikora PiotrSikora requested a review from lizan as a code owner July 1, 2021 22:18
@PiotrSikora PiotrSikora requested a review from moderation July 1, 2021 22:19
WAMR hardcodes 16 KiB stack, which is too small to decode protobufs.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Copy link
Copy Markdown
Contributor

@moderation moderation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This two changes to the existing bazel/repository_locations.bzl Rust Rules and Rust SDK look OK, but this PR brings in additional Rust dependencies via Cargo (I think just protobuf). /cc @htuch to chime in on the extent to which we want to actively maintain and manage dependencies in the Rust / WASM space

@moderation
Copy link
Copy Markdown
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Jul 6, 2021
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm deps

I think it's fine to have Rust fetched independently as long as this isn't in the core and is confined to tests. Ideally we would have the Rust deps in as few places as possible, this is going to be bazel/external/cargo?

@PiotrSikora
Copy link
Copy Markdown
Contributor Author

I think it's fine to have Rust fetched independently as long as this isn't in the core and is confined to tests.

Yes, this is only for tests.

Ideally we would have the Rust deps in as few places as possible, this is going to be bazel/external/cargo?

Correct, and we need this only for Rust deps that are not used in the Rust SDK, since we don't have BUILD rules for them.

@mattklein123 mattklein123 merged commit 5d09fa8 into envoyproxy:main Jul 9, 2021
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
…6722)

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wasm: enable Rust gRPC tests

7 participants