Skip to content

apple dns: fix interface issue with localhost lookup #16369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junr03 merged 2 commits into from
May 7, 2021
Merged

apple dns: fix interface issue with localhost lookup #16369

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e1575e
apple dns: fix interface issue with localhost lookup
May 6, 2021
8af4a94
delete obsolete test
May 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions source/common/network/apple_dns_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,6 @@ void AppleDnsResolverImpl::PendingResolution::onDNSServiceGetAddrInfoReply(
return;
}

ENVOY_BUG(interface_index == 0, fmt::format("unexpected interface_index={}", interface_index));

// Only add this address to the list if kDNSServiceFlagsAdd is set. Callback targets are only
// additive.
if (flags & kDNSServiceFlagsAdd) {
Expand Down
1 change: 1 addition & 0 deletions test/common/network/apple_dns_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ TEST_F(AppleDnsImplTest, DestructPending) {
TEST_F(AppleDnsImplTest, LocalLookup) {
EXPECT_NE(nullptr, resolveWithExpectations("localhost", DnsLookupFamily::Auto,
DnsResolver::ResolutionStatus::Success, true));
dispatcher_->run(Event::Dispatcher::RunType::Block);
}

TEST_F(AppleDnsImplTest, DnsIpAddressVersion) {
Expand Down