test: changing waitForEndStream to fail if it takes 30s#15812
Merged
alyssawilk merged 8 commits intoenvoyproxy:mainfrom Apr 7, 2021
Merged
test: changing waitForEndStream to fail if it takes 30s#15812alyssawilk merged 8 commits intoenvoyproxy:mainfrom
alyssawilk merged 8 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
requested review from
asraa,
dio,
ggreenway,
jmarantz,
lizan,
mattklein123,
snowp and
zuercher
as code owners
Contributor
Author
|
cc @danzh2010 this and the follow-up doing the same for waitForReset should speed up the quic test runs substantially :-) |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
OK, CI happy. PTAL! |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
asraa
reviewed
Apr 7, 2021
Contributor
asraa
left a comment
asraa
left a comment
There was a problem hiding this comment.
Other than that, LGTM, thanks!
/wait
asraa
approved these changes
Apr 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the envoy default timeout of 30s means we had 2 tests waiting for a response that were just hanging 30s.
Fixing both tests (1 overload, 1 quic) and futureproofing.
Risk Level: n/a (test only)
Testing: yes
Docs Changes: n/a
Release Notes: n/a