[Windows] Remove fails_on_windows from quic_protocol_integration_test#15844
[Windows] Remove fails_on_windows from quic_protocol_integration_test#15844alyssawilk merged 1 commit intoenvoyproxy:mainfrom
fails_on_windows from quic_protocol_integration_test#15844Conversation
Signed-off-by: davinci26 <sotirisnan@gmail.com>
|
cc @envoyproxy/windows-dev for visibility |
alyssawilk
left a comment
There was a problem hiding this comment.
LGTM! Want to remove it from quic_http_integration_test while you're in here or does that one not pass on windows?
|
There is a failure specific to |
|
Got it. There are a few timeouts which I'm trying to fix with #15812 and a follow-up I have in a local branch. Once those land I'll see if CI passes or (more likely) if there's still something else up. |
|
Thanks! If there are any Windows specific failures, feel free to open an issue and I will look into them. |
|
Will do! Also if you can easily sort out which test is hanging in the http_protocol_integration_test feel free to #define it out for windows and have the rest running, just to avoid any other windows regressions in the interim. Unfortunately it's a lot more frustrating to figure out what's working and not via CI :-P |
Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com
Commit Message:
Remove
fails_on_windowsfromquic_protocol_integration_test. I have validated this with a couple of thousand runs. I am greedily enabling this test and if this goes south I will mark it asflaky_on_windowsRisk Level: Low (Test only)
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A