Skip to content

[Windows] Remove fails_on_windows from quic_protocol_integration_test#15844

Merged
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
davinci26:quicTestWindows
Apr 6, 2021
Merged

[Windows] Remove fails_on_windows from quic_protocol_integration_test#15844
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
davinci26:quicTestWindows

Conversation

@davinci26
Copy link
Copy Markdown
Member

Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com
Commit Message:

Remove fails_on_windows from quic_protocol_integration_test. I have validated this with a couple of thousand runs. I am greedily enabling this test and if this goes south I will mark it as flaky_on_windows

Risk Level: Low (Test only)
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: davinci26 <sotirisnan@gmail.com>
@davinci26
Copy link
Copy Markdown
Member Author

@alyssawilk

cc @envoyproxy/windows-dev for visibility

Copy link
Copy Markdown
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Want to remove it from quic_http_integration_test while you're in here or does that one not pass on windows?

@davinci26
Copy link
Copy Markdown
Member Author

There is a failure specific to quic_http_integration_test that causes it to time out GCP RBE. I think it is because the test takes too long on Windows so I can't remove it now. I will have to investigate this on further

@alyssawilk alyssawilk merged commit da2c977 into envoyproxy:main Apr 6, 2021
@alyssawilk
Copy link
Copy Markdown
Contributor

Got it. There are a few timeouts which I'm trying to fix with #15812 and a follow-up I have in a local branch. Once those land I'll see if CI passes or (more likely) if there's still something else up.
Meanwhile as I turn up more tests for QUIC I'll make sure to run them on windows if they pass (e.g. https://github.com/envoyproxy/envoy/pull/15841/files)

@davinci26
Copy link
Copy Markdown
Member Author

Thanks! If there are any Windows specific failures, feel free to open an issue and I will look into them.

@alyssawilk
Copy link
Copy Markdown
Contributor

Will do! Also if you can easily sort out which test is hanging in the http_protocol_integration_test feel free to #define it out for windows and have the rest running, just to avoid any other windows regressions in the interim. Unfortunately it's a lot more frustrating to figure out what's working and not via CI :-P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants