Merged
Conversation
…for egress operations.
include/envoy/tracing/http_tracer.h
Outdated
| * Http Tracing can be enabled/disabled on a per connection manager basis. | ||
| * Here we specify some specific for connection manager settings. | ||
| */ | ||
| struct TracingConnectionManagerConfig { |
Member
There was a problem hiding this comment.
doesn't need to be in public includes. I don't think TracingType does either.
Member
Author
There was a problem hiding this comment.
right, moving that out.
| * @return true if tracing is enabled otherwise it returns false; | ||
| */ | ||
| virtual bool isTracing() PURE; | ||
| virtual bool isTracing(const Http::AccessLog::RequestInfo& request_info) PURE; |
Member
There was a problem hiding this comment.
I would rename shouldTraceRequest(...)
| /** | ||
| * TODO: comment. | ||
| */ | ||
| virtual const Optional<Tracing::TracingConnectionManagerConfig>& tracingInfo() PURE; |
Member
There was a problem hiding this comment.
I would rename tracingConfig()
ccaraman
reviewed
Oct 17, 2016
| } | ||
|
|
||
| // This should not happen as switch above covers all cases, this is just to make compiler happy. | ||
| throw EnvoyException("unknown tracing type"); |
Contributor
There was a problem hiding this comment.
Can you add the tracing_type value to the exception?
Member
There was a problem hiding this comment.
Just use NOT_IMPLEMENTED or something clear that it should not happen
Member
Author
There was a problem hiding this comment.
i'll switch to NOT_IMPLEMENTED here and refine the comment to emphasize that compiler also enforces all types covered by switch above.
| data to the :ref:`configured tracing provider <config_tracing>`. Defaults to false. | ||
| .. _config_http_conn_man_tracing: | ||
|
|
||
| tracing |
Member
There was a problem hiding this comment.
generally a sub-level json object gets its own section (see other docs). Can you make a new section on this page, put the nested json docs there, and link to it from here (again see other docs)
|
|
||
| namespace Tracing { | ||
|
|
||
| class TracingContext { |
| // Trace all traceable requests. | ||
| All, | ||
| // Trace only when there is an upstream failure reason. | ||
| UpstreamFailureReason |
Member
There was a problem hiding this comment.
I would call this UpstreamFailure
mattklein123
approved these changes
Oct 17, 2016
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
PiotrSikora
added a commit
to PiotrSikora/envoy
that referenced
this pull request
Aug 27, 2019
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora
added a commit
to PiotrSikora/envoy
that referenced
this pull request
Feb 22, 2020
* Cache and share the base Wasm (envoyproxy#387) Cache and share the base Wasm. Use the new definition of Wasm Key to find the base Wasm and thread local Wasm. Signed-off-by: John Plevyak <jplevyak@gmail.com> * Only call proxy_on_vm_start() when the VM is actaully starting. (envoyproxy#400) Signed-off-by: John Plevyak <jplevyak@gmail.com> * Fix SEGV when reusing the base vm. (envoyproxy#413) Signed-off-by: John Plevyak <jplevyak@gmail.com> Co-authored-by: John Plevyak <jplevyak@gmail.com>
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
zh-translation: /intro/arch_overview/other_features/compression/libraries.rst
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Jose Nino jnino@lyft.com Description: fix small typo Risk Level: low -- fix inline comment typo Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Jose Nino jnino@lyft.com Description: fix small typo Risk Level: low -- fix inline comment typo Signed-off-by: JP Simard <jp@jpsim.com>
arminabf
pushed a commit
to arminabf/envoy
that referenced
this pull request
Jun 5, 2024
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work is in progress for this item. Need to add tests etc.