Skip to content

cluster manager: gracefully handle static/cds cluster manager init#387

Merged
mattklein123 merged 3 commits intomasterfrom
cds_init
Jan 28, 2017
Merged

cluster manager: gracefully handle static/cds cluster manager init#387
mattklein123 merged 3 commits intomasterfrom
cds_init

Conversation

@mattklein123
Copy link
Member

This change refactors CM init so that we can properly do initialization
across static clusters as well as CDS clusters. The normal init flow
looks like this:

  1. Initialize static primary clusters
  2. Initialize static secondary clusters
  3. Start CDS fetch
  4. Initialize CDS primary clusters
  5. Initialize CDS secondary clusters

This should now work correectly if any of the phases are absent or
immediately complete (as in the case of static clusters).

fixes #367
fixes #330

This change refactors CM init so that we can properly do initialization
across static clusters as well as CDS clusters. The normal init flow
looks like this:
1) Initialize static primary clusters
2) Initialize static secondary clusters
3) Start CDS fetch
4) Initialize CDS primary clusters
5) Initialize CDS secondary clusters

This should now work correectly if any of the phases are absent or
immediately complete (as in the case of static clusters).

fixes #367
fixes #330
@mattklein123
Copy link
Member Author

@lyft/network-team

@mattklein123 mattklein123 merged commit c31c877 into master Jan 28, 2017
@mattklein123 mattklein123 deleted the cds_init branch January 28, 2017 00:05
PiotrSikora pushed a commit to PiotrSikora/envoy that referenced this pull request Feb 21, 2020
Cache and share the base Wasm.  Use the new definition of Wasm Key to
find the base Wasm and thread local Wasm.

Signed-off-by: John Plevyak <jplevyak@gmail.com>
bianpengyuan pushed a commit to istio/envoy that referenced this pull request Feb 22, 2020
* Cache and share the base Wasm (envoyproxy#387)

Cache and share the base Wasm.  Use the new definition of Wasm Key to
find the base Wasm and thread local Wasm.

Signed-off-by: John Plevyak <jplevyak@gmail.com>

* Only call proxy_on_vm_start() when the VM is actaully starting. (envoyproxy#400)

Signed-off-by: John Plevyak <jplevyak@gmail.com>

* Fix SEGV when reusing the base vm. (envoyproxy#413)

Signed-off-by: John Plevyak <jplevyak@gmail.com>

Co-authored-by: John Plevyak <jplevyak@gmail.com>
PiotrSikora pushed a commit to istio/envoy that referenced this pull request Feb 24, 2020
* Cache and share the base Wasm.  Use the new definition of Wasm Key to
find the base Wasm and thread local Wasm.

Signed-off-by: John Plevyak <jplevyak@gmail.com>
wolfguoliang pushed a commit to wolfguoliang/envoy that referenced this pull request Jan 23, 2021
kyessenov pushed a commit to kyessenov/envoy that referenced this pull request Sep 10, 2021
* Cache and share the base Wasm.  Use the new definition of Wasm Key to
find the base Wasm and thread local Wasm.

Signed-off-by: John Plevyak <jplevyak@gmail.com>
jpsim pushed a commit that referenced this pull request Nov 28, 2022
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need working service discovery Example Config. Dynamic clusters add/remove, stats, and hot restart

2 participants