Add access log handler for HTTP stream filter.#400
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Feb 1, 2017
Merged
Add access log handler for HTTP stream filter.#400mattklein123 merged 4 commits intoenvoyproxy:masterfrom
mattklein123 merged 4 commits intoenvoyproxy:masterfrom
Conversation
Member
|
this looks reasonable to me. tests please. |
include/envoy/http/filter.h
Outdated
Member
There was a problem hiding this comment.
can we also pass request/response headers (optionally) like the other access log calls? Might be useful for others in the future.
Contributor
Author
|
@RomanDzhabarov and @mattklein123 |
qiwzhang
force-pushed
the
access_log_filter
branch
from
11b7898 to
6e01517
Compare
Contributor
Author
|
@RomanDzhabarov and @mattklein123. I changed to use Http::Accesslog::Instance directly and added a test case. Could you help to review it again? Thanks. |
mattklein123
reviewed
Feb 1, 2017
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
looks good, just a small comment fix.
include/envoy/http/filter.h
Outdated
| virtual void addStreamFilter(Http::StreamFilterPtr filter) PURE; | ||
|
|
||
| /** | ||
| * Add an access log handler that is called after response is send. |
Member
There was a problem hiding this comment.
"Add an access log handler that is called when the stream is destroyed." (A response may not have been sent)
mattklein123
approved these changes
Feb 1, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of mixerclient This PR will be merged automatically once checks are successful. ```release-note none ```
PiotrSikora
pushed a commit
to PiotrSikora/envoy
that referenced
this pull request
Feb 21, 2020
…yproxy#400) Signed-off-by: John Plevyak <jplevyak@gmail.com>
bianpengyuan
pushed a commit
to istio/envoy
that referenced
this pull request
Feb 22, 2020
* Cache and share the base Wasm (envoyproxy#387) Cache and share the base Wasm. Use the new definition of Wasm Key to find the base Wasm and thread local Wasm. Signed-off-by: John Plevyak <jplevyak@gmail.com> * Only call proxy_on_vm_start() when the VM is actaully starting. (envoyproxy#400) Signed-off-by: John Plevyak <jplevyak@gmail.com> * Fix SEGV when reusing the base vm. (envoyproxy#413) Signed-off-by: John Plevyak <jplevyak@gmail.com> Co-authored-by: John Plevyak <jplevyak@gmail.com>
PiotrSikora
pushed a commit
to istio/envoy
that referenced
this pull request
Feb 24, 2020
Only call proxy_on_vm_start() when the VM is actually starting.
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
…verload_manager.rst (envoyproxy#400) * translation overload_manager.rst * translation overload_manager.rst * translation overload_manager.rst * translation overload_manager.rst Co-authored-by: 包仁义 <renyi.bao@yiducloud.cn>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: delete dispatcher todo that is done. This TODO is done as when cleanup happens it is guaranteed that core Envoy will not fire anymore callbacks on that stream, and additionally the platform has also locally closed the stream. Risk Level: low Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: delete dispatcher todo that is done. This TODO is done as when cleanup happens it is guaranteed that core Envoy will not fire anymore callbacks on that stream, and additionally the platform has also locally closed the stream. Risk Level: low Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** There was a race condition in extproc package's TestStartConfigWatcher test. **Related Issues/PRs (if applicable)** Follow up on #392 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #393