coverage: adjust threshold on source/server to fix flaky failure#15238
Merged
alyssawilk merged 2 commits intoenvoyproxy:mainfrom Mar 1, 2021
Merged
coverage: adjust threshold on source/server to fix flaky failure#15238alyssawilk merged 2 commits intoenvoyproxy:mainfrom
alyssawilk merged 2 commits intoenvoyproxy:mainfrom
Conversation
The coverage recently has been flaky between 94.4 and 95.1. What's worse is this is somehow deterministic, i.e. on some pull requests, retesting would not work to go green. Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Member
|
+1 #15117 |
jmarantz
reviewed
Mar 1, 2021
Contributor
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
Basically LGTM: I think it's something we need to fix but the flakiness of this coverage issue should not be a tax on all unrelated PRs.
But can you add an Issue describing what you've learned about the flake, and reference it here from this comment, so we are not tempted to "tighten" the coverage requirements again and re-introduce flakes?
Member
Author
Agreed. I'm on it. |
Member
Author
|
#15239 created the tracker. |
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
jmarantz
approved these changes
Mar 1, 2021
alyssawilk
approved these changes
Mar 1, 2021
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Thanks for the fix + issue and sorry for the noise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coverage on source/server recently has been flaky between 94.4 and 95.1. What's worse is
this is somehow deterministic, i.e. on some commits, retesting would not work to go green.
I have encountered this several times in a last few weeks, for example, #15210 this is clearly unrelated to this coverage issue. You can see the same flake is happening to other PRs.
I see that the root cause sits in
source/server/connection_handler_impl.cc, but I would like to introduce this change as a temporary workaround.Signed-off-by: Takeshi Yoneda takeshi@tetrate.io