wasm: refactor common codes around configurations#15210
Merged
mattklein123 merged 7 commits intoenvoyproxy:mainfrom Mar 2, 2021
Merged
wasm: refactor common codes around configurations#15210mattklein123 merged 7 commits intoenvoyproxy:mainfrom
mattklein123 merged 7 commits intoenvoyproxy:mainfrom
Conversation
repokitteh-read-only
bot
added
the
deps
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
mathetake
force-pushed
the
wasm-config
branch
from
baad35f to
d0f5163
Compare
PiotrSikora
reviewed
Feb 27, 2021
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Contributor
|
@mathetake it looks that you forgot to add some files. |
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Member
Author
|
sorry, I missed them. I just Added. |
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
|
@mathetake that failure is deterministic (coverage is too low) and I believe unrelated to this PR. Merging |
PiotrSikora
reviewed
Mar 1, 2021
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Member
Author
Unfortunately the branch is already up-to-date, so I believe something is broken on main branch, and that's unrelated to this PR since the same happens on other PRs. |
This was referenced Mar 1, 2021
Member
Author
|
coverage failure will be fixed in #15238 |
alyssawilk
pushed a commit
that referenced
this pull request
Mar 1, 2021
) The coverage on source/server recently has been flaky between 94.4 and 95.1. What's worse is this is somehow deterministic, i.e. on some commits, retesting would not work to go green. I have encountered this several times in a last few weeks, for example, #15210 this is clearly unrelated to this coverage issue. You can see the same flake is happening to other PRs. I see that the root cause sits in source/server/connection_handler_impl.cc, but I would like to introduce this change as a temporary workaround. Signed-off-by: Takeshi Yoneda takeshi@tetrate.io
alyssawilk
pushed a commit
that referenced
this pull request
Mar 5, 2021
PiotrSikora
added a commit
to PiotrSikora/envoy
that referenced
this pull request
Mar 23, 2021
Broken during refactor in envoyproxy#15210. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Merged
lizan
pushed a commit
that referenced
this pull request
Mar 23, 2021
Broken during refactor in #15210. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored wasm common codes around configurations by introducing
WasmConfigclass which performs conversion of restriction configs (and other configs in the future). Resolved the comment istio/proxy#3202 (comment).