Update Envoy SHA to latest.#3202
Merged
istio-testing merged 2 commits intoistio:masterfrom Feb 19, 2021
Merged
Conversation
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
google-cla
bot
added
the
cla: yes
istio-testing
added
the
size/M
bianpengyuan
approved these changes
Feb 19, 2021
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora
commented
Feb 19, 2021
| std::make_shared<IstioWasm>(vm_config.runtime(), vm_config.vm_id(), | ||
| anyToBytes(vm_config.configuration()), | ||
| vm_key, scope, cluster_manager, dispatcher); | ||
| // TODO(rapilado): make this transformation in Proxy-Wasm C++ Host. |
Contributor
Author
There was a problem hiding this comment.
@ryanapilado it looks that this leaks quite a bit and each extension needs to convert CapabilityRestrictionConfig to allowed_capabilities, which seems a bit error prone. We should do it earlier in the process (either in Proxy-Wasm C++ host or Envoy) to avoid this repetition.
cc @mathetake to catch similiar issues in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Sikora piotrsikora@google.com