backport to 1.16: http: fixing a bug with IPv6 hosts#14238
Merged
alyssawilk merged 3 commits intoenvoyproxy:release/v1.16from Dec 3, 2020
Merged
backport to 1.16: http: fixing a bug with IPv6 hosts#14238alyssawilk merged 3 commits intoenvoyproxy:release/v1.16from
alyssawilk merged 3 commits intoenvoyproxy:release/v1.16from
Conversation
Fixing a bug where HTTP parser offsets for IPv6 hosts did not include [] and Envoy assumed it did. This results in mis-parsing addresses for IPv6 CONNECT requests and IPv6 hosts in fully URLs over HTTP/1.1 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Shikugawa <rei@tetrate.io>
Signed-off-by: Shikugawa <rei@tetrate.io>
Member
Author
|
cc @cpakulski |
alyssawilk
reviewed
Dec 2, 2020
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Thank you for doing backports! LGTM modulo the release note comment
I'm out for much of today so feel free to have someone else stamp once the docs comment is addressed, otherwise can approve tomorrow.
| *Changes expected to improve the state of the world and are unlikely to have negative effects* | ||
| * examples: examples use v3 configs. | ||
| * http: fixed URL parsing for HTTP/1.1 fully qualified URLs and connect requests containing IPv6 addresses. | ||
| * http: sending CONNECT_ERROR for HTTP/2 where appropriate during CONNECT requests. |
Contributor
There was a problem hiding this comment.
did you paste an extra note here?
Member
Author
There was a problem hiding this comment.
what you say means this change?
Signed-off-by: Shikugawa <rei@tetrate.io>
alyssawilk
approved these changes
Dec 3, 2020
istio-testing
pushed a commit
to istio/envoy
that referenced
this pull request
Feb 5, 2021
* backport to 1.16: http: fixing a bug with IPv6 hosts (envoyproxy#14238) Fixing a bug where HTTP parser offsets for IPv6 hosts did not include [] and Envoy assumed it did. This results in mis-parsing addresses for IPv6 CONNECT requests and IPv6 hosts in fully URLs over HTTP/1.1 Risk Level: low Testing: new unit, integration tests Docs Changes: n/a Release Notes: inline Signed-off-by: Shikugawa <rei@tetrate.io> Co-authored-by: alyssawilk <alyssar@chromium.org> * backport to 1.16: vrp: allow supervisord to open its log file (envoyproxy#14066) (envoyproxy#14279) Commit Message: Allow supervisord to open its log file Additional Description: Change the default location of the log file and give supervisord permissions to write to it. Risk Level: low Testing: built image locally Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Alex Konradi <akonradi@google.com> Signed-off-by: Christoph Pakulski <christoph@tetrate.io> * Closing release 1.16.2. (envoyproxy#14308) Signed-off-by: Christoph Pakulski <christoph@tetrate.io> * Kick-off rel 1.16.3. (envoyproxy#14321) Signed-off-by: Christoph Pakulski <christoph@tetrate.io> * lua: reset downstream_ssl_connection in StreamInfoWrapper when object is marked dead by Lua GC (envoyproxy#14092) (envoyproxy#14449) Co-authored-by: Marcin Falkowski <marcin.falkowski@allegro.pl> * backport to 1.16: tls: fix detection of the upstream connection close event. (envoyproxy#13858) (envoyproxy#14452) Fixes envoyproxy#13856. This change also contains the following backports: - build: Fix some unused variable warnings (envoyproxy#13987) - test: Check in all TLS test certs (envoyproxy#13702) Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Christoph Pakulski <christoph@tetrate.io> * backport to 1.16: aggregate cluster: fix TLS init issue (envoyproxy#14456) Additional Description: Based on envoyproxy#14388 Risk Level: Low Testing: Build and run the repro from envoyproxy#14119 without crashing, `bazel test test/extensions/clusters/aggregate:cluster_test` Docs Changes: N/A Release Notes: envoyproxy#14119 Signed-off-by: Taylor Barrella <tabarr@google.com> Co-authored-by: Rei Shimizu <rei@tetrate.io> Co-authored-by: Christoph Pakulski <christoph@tetrate.io> Co-authored-by: Marcin Falkowski <marcin.falkowski@allegro.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Fixing a bug where HTTP parser offsets for IPv6 hosts did not include [] and Envoy assumed it did.
This results in mis-parsing addresses for IPv6 CONNECT requests and IPv6 hosts in fully URLs over HTTP/1.1
Risk Level: low
Testing: new unit, integration tests
Docs Changes: n/a
Release Notes: inline