lua: reset downstream_ssl_connection in StreamInfoWrapper when object is marked dead by Lua GC by MarcinFalkowski · Pull Request #14092 · envoyproxy/envoy

MarcinFalkowski · 2020-11-19T08:53:16Z

Fixes #14091

The problem and fix is similiar to #4312

Risk Level: Low
Testing: regression test, manual testing
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Marcin Falkowski <marcin.falkowski@allegro.pl>

…connection-segfault-fix Signed-off-by: Marcin Falkowski <marcin.falkowski@allegro.pl>

Signed-off-by: Marcin Falkowski <marcin.falkowski@allegro.pl>

MarcinFalkowski · 2020-11-19T15:36:53Z

I am not sure, but it looks like CI failed for reasons unrelated to this change (Windows build hanged)

MarcinFalkowski · 2020-11-19T15:38:58Z

@dio just letting you know. Maybe you will be interested in reviewing this.

MarcinFalkowski · 2020-11-20T07:42:15Z

/retest

repokitteh-read-only · 2020-11-20T07:42:19Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14092 (comment) was created by @MarcinFalkowski.

see: more, trace.

MarcinFalkowski · 2020-11-20T15:48:19Z

/retest

repokitteh-read-only · 2020-11-20T15:48:23Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14092 (comment) was created by @MarcinFalkowski.

see: more, trace.

…connection-segfault-fix Signed-off-by: Marcin Falkowski <marcin.falkowski@allegro.pl>

dio · 2020-11-21T02:06:33Z

Thank you for this! @MarcinFalkowski could you try to merge main? Hopefully the coverage test failure will be fixed.

…connection-segfault-fix Signed-off-by: Marcin Falkowski <marcin.falkowski@allegro.pl>

dio

Looks good. I think you need to merge master. And one super nit and an ask for help.

dio · 2020-11-21T02:20:30Z

test/extensions/filters/http/lua/lua_filter_test.cc

+
+  setup(SCRIPT);
+
+  auto connection_info = std::make_shared<Ssl::MockConnectionInfo>();


Nit. use const? And since you're here probably the above one too.

Thanks for a review. I will fix it. Just to be sure - by "above one" you mean the other instance of auto connection_info = std::make_shared<Ssl::MockConnectionInfo>(); in this file?

Yes, you're correct. Thank you so much!

Signed-off-by: Marcin Falkowski <marcin.falkowski@allegro.pl>

dio

Super cool. Thank you for working on this!

MarcinFalkowski · 2020-11-21T05:10:09Z

@dio CI is green. Hope we can merge it now. Thanks for a review

dio · 2020-11-23T05:34:16Z

@mattklein123 do you want to take another look at this? And should we backport this? Thank you! cc. @cpakulski

… is marked dead by Lua GC (envoyproxy#14092) Fixes envoyproxy#14091 The problem and fix is similiar to envoyproxy#4312 Risk Level: Low Testing: regression test, manual testing Docs Changes: N/A Release Notes: N/A Signed-off-by: Marcin Falkowski <marcin.falkowski@allegro.pl>

… is marked dead by Lua GC (envoyproxy#14092) Fixes envoyproxy#14091 The problem and fix is similiar to envoyproxy#4312 Risk Level: Low Testing: regression test, manual testing Docs Changes: N/A Release Notes: N/A Signed-off-by: Marcin Falkowski <marcin.falkowski@allegro.pl> Signed-off-by: Qin Qin <qqin@google.com>

… is marked dead by Lua GC (envoyproxy#14092) Fixes envoyproxy#14091 The problem and fix is similiar to envoyproxy#4312 Risk Level: Low Testing: regression test, manual testing Docs Changes: N/A Release Notes: N/A Signed-off-by: Marcin Falkowski <marcin.falkowski@allegro.pl> Signed-off-by: Christoph Pakulski <christoph@tetrate.io>

… is marked dead by Lua GC (#14092) (#14449) Co-authored-by: Marcin Falkowski <marcin.falkowski@allegro.pl>

cpakulski · 2021-01-05T20:29:05Z

Backports to releases 1.13-1.15 are not required because SSL connection is not exposed through LUA in those releases.
Backport completed. Removing "backport/approved" label.

* backport to 1.16: http: fixing a bug with IPv6 hosts (envoyproxy#14238) Fixing a bug where HTTP parser offsets for IPv6 hosts did not include [] and Envoy assumed it did. This results in mis-parsing addresses for IPv6 CONNECT requests and IPv6 hosts in fully URLs over HTTP/1.1 Risk Level: low Testing: new unit, integration tests Docs Changes: n/a Release Notes: inline Signed-off-by: Shikugawa <rei@tetrate.io> Co-authored-by: alyssawilk <alyssar@chromium.org> * backport to 1.16: vrp: allow supervisord to open its log file (envoyproxy#14066) (envoyproxy#14279) Commit Message: Allow supervisord to open its log file Additional Description: Change the default location of the log file and give supervisord permissions to write to it. Risk Level: low Testing: built image locally Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Alex Konradi <akonradi@google.com> Signed-off-by: Christoph Pakulski <christoph@tetrate.io> * Closing release 1.16.2. (envoyproxy#14308) Signed-off-by: Christoph Pakulski <christoph@tetrate.io> * Kick-off rel 1.16.3. (envoyproxy#14321) Signed-off-by: Christoph Pakulski <christoph@tetrate.io> * lua: reset downstream_ssl_connection in StreamInfoWrapper when object is marked dead by Lua GC (envoyproxy#14092) (envoyproxy#14449) Co-authored-by: Marcin Falkowski <marcin.falkowski@allegro.pl> * backport to 1.16: tls: fix detection of the upstream connection close event. (envoyproxy#13858) (envoyproxy#14452) Fixes envoyproxy#13856. This change also contains the following backports: - build: Fix some unused variable warnings (envoyproxy#13987) - test: Check in all TLS test certs (envoyproxy#13702) Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Christoph Pakulski <christoph@tetrate.io> * backport to 1.16: aggregate cluster: fix TLS init issue (envoyproxy#14456) Additional Description: Based on envoyproxy#14388 Risk Level: Low Testing: Build and run the repro from envoyproxy#14119 without crashing, `bazel test test/extensions/clusters/aggregate:cluster_test` Docs Changes: N/A Release Notes: envoyproxy#14119 Signed-off-by: Taylor Barrella <tabarr@google.com> Co-authored-by: Rei Shimizu <rei@tetrate.io> Co-authored-by: Christoph Pakulski <christoph@tetrate.io> Co-authored-by: Marcin Falkowski <marcin.falkowski@allegro.pl>

MarcinFalkowski added 4 commits November 17, 2020 20:55

streamInfo onMarkDead -> clear downstream_ssl_connection_

a5addee

Signed-off-by: Marcin Falkowski <marcin.falkowski@allegro.pl>

regression test

4b91041

Signed-off-by: Marcin Falkowski <marcin.falkowski@allegro.pl>

Merge remote-tracking branch 'origin/master' into lua-downstream-ssl-…

c068718

…connection-segfault-fix Signed-off-by: Marcin Falkowski <marcin.falkowski@allegro.pl>

add issue number to regression test

634382d

Signed-off-by: Marcin Falkowski <marcin.falkowski@allegro.pl>

MarcinFalkowski mentioned this pull request Nov 19, 2020

use envoy version with segfault fix allegro/envoy-control#216

Merged

MarcinFalkowski closed this in allegro/envoy-control#216 Nov 20, 2020

MarcinFalkowski reopened this Nov 20, 2020

Merge remote-tracking branch 'origin/master' into lua-downstream-ssl-…

24dc57b

…connection-segfault-fix Signed-off-by: Marcin Falkowski <marcin.falkowski@allegro.pl>

mattklein123 assigned dio Nov 20, 2020

Merge remote-tracking branch 'origin/master' into lua-downstream-ssl-…

b99f3d5

…connection-segfault-fix Signed-off-by: Marcin Falkowski <marcin.falkowski@allegro.pl>

dio reviewed Nov 21, 2020

View reviewed changes

add const modifier

093ce9f

Signed-off-by: Marcin Falkowski <marcin.falkowski@allegro.pl>

dio approved these changes Nov 21, 2020

View reviewed changes

lizan approved these changes Nov 23, 2020

View reviewed changes

lizan added the backport/review Request to backport to stable releases label Nov 23, 2020

lizan merged commit 59e2968 into envoyproxy:master Nov 23, 2020

slonka mentioned this pull request Dec 6, 2020

Service identity injection to request payload kumahq/kuma#1256

Closed

cpakulski added backport/approved Approved backports to stable releases and removed backport/review Request to backport to stable releases labels Dec 16, 2020

dio pushed a commit that referenced this pull request Dec 22, 2020

lua: reset downstream_ssl_connection in StreamInfoWrapper when object…

db0ae3d

… is marked dead by Lua GC (#14092) (#14449) Co-authored-by: Marcin Falkowski <marcin.falkowski@allegro.pl>

cpakulski removed the backport/approved Approved backports to stable releases label Jan 5, 2021


		setup(SCRIPT);

		auto connection_info = std::make_shared<Ssl::MockConnectionInfo>();

Conversation

MarcinFalkowski commented Nov 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MarcinFalkowski commented Nov 19, 2020

Uh oh!

MarcinFalkowski commented Nov 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MarcinFalkowski commented Nov 20, 2020

Uh oh!

repokitteh-read-only bot commented Nov 20, 2020

Uh oh!

MarcinFalkowski commented Nov 20, 2020

Uh oh!

repokitteh-read-only bot commented Nov 20, 2020

Uh oh!

dio commented Nov 21, 2020

Uh oh!

dio left a comment

Choose a reason for hiding this comment

Uh oh!

dio Nov 21, 2020

Choose a reason for hiding this comment

Uh oh!

MarcinFalkowski Nov 21, 2020

Choose a reason for hiding this comment

Uh oh!

dio Nov 21, 2020

Choose a reason for hiding this comment

Uh oh!

MarcinFalkowski Nov 21, 2020

Choose a reason for hiding this comment

Uh oh!

dio left a comment

Choose a reason for hiding this comment

Uh oh!

MarcinFalkowski commented Nov 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dio commented Nov 23, 2020

Uh oh!

cpakulski commented Jan 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MarcinFalkowski commented Nov 19, 2020 •

edited

Loading

MarcinFalkowski commented Nov 19, 2020 •

edited

Loading

MarcinFalkowski commented Nov 21, 2020 •

edited

Loading