Skip to content

test: Check in all TLS test certs#13702

Merged
lizan merged 2 commits intoenvoyproxy:masterfrom
greenhouse-org:check-in-tls-test-certs
Oct 22, 2020
Merged

test: Check in all TLS test certs#13702
lizan merged 2 commits intoenvoyproxy:masterfrom
greenhouse-org:check-in-tls-test-certs

Conversation

@sunjayBhatia
Copy link
Member

@sunjayBhatia sunjayBhatia commented Oct 22, 2020 •
edited
Loading

Commit Message: test: Check in all TLS test certs
Additional Description:

Risk Level: Low
Testing: Verified on Linux and Windows locally, modifies unit test setup
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

@sunjayBhatia
test: Check in all TLS test certs
e147ea1 
- Will prevent openssl fork-emulation issues on Windows/msys2 that cause
  test flakiness
- modifies context_impl_test to no longer requires a cert that is
  generated on the fly to expire in 15 days

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
This was referenced Oct 22, 2020
Closed
Merged
@davinci26
Copy link
Member

davinci26 commented Oct 22, 2020

+1 as it helps with removing test dependencies on bash files.

Test that run on bash script are painful on Windows since you need to go through some hoops to attach a debugger.

@sunjayBhatia
Copy link
Member Author

sunjayBhatia commented Oct 22, 2020

/retest

I specifically ran the format and spelling check locally via Docker so this one is confusing

@repokitteh-read-only
Copy link

repokitteh-read-only bot commented Oct 22, 2020

Retrying Azure Pipelines.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #13702 (comment) was created by @sunjayBhatia.

see: more, trace.

@phlax
Copy link
Member

phlax commented Oct 22, 2020

@sunjayBhatia see here https://dev.azure.com/cncf/envoy/_build/results?buildId=55029&view=logs&j=a9c3f16a-7a41-5cb0-a55b-0d11e9c98c50&t=044b2326-1800-5bcd-b44b-584adc5b0b85&l=154

lizan
lizan reviewed Oct 22, 2020
View reviewed changes
Copy link
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me.

@sunjayBhatia
Copy link
Member Author

sunjayBhatia commented Oct 22, 2020

@sunjayBhatia see here https://dev.azure.com/cncf/envoy/_build/results?buildId=55029&view=logs&j=a9c3f16a-7a41-5cb0-a55b-0d11e9c98c50&t=044b2326-1800-5bcd-b44b-584adc5b0b85&l=154

Shellcheck! Ha I didn’t read that far up in the output, thanks @phlax

@phlax
Copy link
Member

phlax commented Oct 22, 2020

i added a ticket as its kinda annoying it doesnt give better output #13709

@sunjayBhatia
Shellcheck and perm fix
eb9d001 
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia requested a review from lizan October 22, 2020 13:59
@sunjayBhatia
Copy link
Member Author

sunjayBhatia commented Oct 22, 2020

huh, all stages are finished but github thinks the pipeline overall is not

@lizan
Copy link
Member

lizan commented Oct 22, 2020

huh, all stages are finished but github thinks the pipeline overall is not

sounds like either GH issue or AZP issue, but it is not blocking anyway.

@lizan lizan merged commit 9ff2d69 into envoyproxy:master Oct 22, 2020
@sunjayBhatia sunjayBhatia deleted the check-in-tls-test-certs branch October 22, 2020 23:07
@sunjayBhatia sunjayBhatia mentioned this pull request Oct 22, 2020
Closed
chradcliffe pushed a commit to chradcliffe/envoy that referenced this pull request Oct 23, 2020
@sunjayBhatia
test: Check in all TLS test certs (envoyproxy#13702)
7afc155 
* test: Check in all TLS test certs

- Will prevent openssl fork-emulation issues on Windows/msys2 that cause
  test flakiness
- modifies context_impl_test to no longer requires a cert that is
  generated on the fly to expire in 15 days

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Craig Radcliffe <craig.radcliffe@broadcom.com>
@cpakulski cpakulski mentioned this pull request Dec 18, 2020
Merged
cpakulski pushed a commit to cpakulski/envoy that referenced this pull request Dec 22, 2020
@sunjayBhatia @cpakulski
test: Check in all TLS test certs (envoyproxy#13702)
2d39d82 
* test: Check in all TLS test certs

- Will prevent openssl fork-emulation issues on Windows/msys2 that cause
  test flakiness
- modifies context_impl_test to no longer requires a cert that is
  generated on the fly to expire in 15 days

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
antoniovicente pushed a commit that referenced this pull request Dec 29, 2020
@cpakulski
backport to 1.16: tls: fix detection of the upstream connection close…
15f02f0 
… event. (#13858) (#14452)

Fixes #13856.

This change also contains the following backports:
- build: Fix some unused variable warnings (#13987)
- test: Check in all TLS test certs (#13702)

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
istio-testing pushed a commit to istio/envoy that referenced this pull request Feb 5, 2021
@tbarrella @Shikugawa
@cpakulski @MarcinFalkowski
Merge envoy/release/v1.16 into release-1.8 (#294)
5b0c5f7 
* backport to 1.16: http: fixing a bug with IPv6 hosts (envoyproxy#14238)

Fixing a bug where HTTP parser offsets for IPv6 hosts did not include [] and Envoy assumed it did.
This results in mis-parsing addresses for IPv6 CONNECT requests and IPv6 hosts in fully URLs over HTTP/1.1

Risk Level: low
Testing: new unit, integration tests
Docs Changes: n/a
Release Notes: inline
Signed-off-by: Shikugawa <rei@tetrate.io>
Co-authored-by: alyssawilk <alyssar@chromium.org>

* backport to 1.16: vrp: allow supervisord to open its log file (envoyproxy#14066) (envoyproxy#14279)

Commit Message: Allow supervisord to open its log file
Additional Description:
Change the default location of the log file and give supervisord
permissions to write to it.

Risk Level: low
Testing: built image locally
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Alex Konradi <akonradi@google.com>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>

* Closing release 1.16.2. (envoyproxy#14308)

Signed-off-by: Christoph Pakulski <christoph@tetrate.io>

* Kick-off rel 1.16.3. (envoyproxy#14321)

Signed-off-by: Christoph Pakulski <christoph@tetrate.io>

* lua: reset downstream_ssl_connection in StreamInfoWrapper when object is marked dead by Lua GC (envoyproxy#14092) (envoyproxy#14449)

Co-authored-by: Marcin Falkowski <marcin.falkowski@allegro.pl>

* backport to 1.16: tls: fix detection of the upstream connection close event. (envoyproxy#13858) (envoyproxy#14452)

Fixes envoyproxy#13856.

This change also contains the following backports:
- build: Fix some unused variable warnings (envoyproxy#13987)
- test: Check in all TLS test certs (envoyproxy#13702)

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>

* backport to 1.16: aggregate cluster: fix TLS init issue (envoyproxy#14456)

Additional Description: Based on envoyproxy#14388
Risk Level: Low
Testing: Build and run the repro from envoyproxy#14119 without crashing, `bazel test test/extensions/clusters/aggregate:cluster_test`
Docs Changes: N/A
Release Notes:
envoyproxy#14119

Signed-off-by: Taylor Barrella <tabarr@google.com>

Co-authored-by: Rei Shimizu <rei@tetrate.io>
Co-authored-by: Christoph Pakulski <christoph@tetrate.io>
Co-authored-by: Marcin Falkowski <marcin.falkowski@allegro.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PiotrSikora PiotrSikora Awaiting requested review from PiotrSikora

1 more reviewer

@lizan lizan lizan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sunjayBhatia @davinci26 @phlax @lizan