config: v2 fatal-by-default.#13950
Merged
htuch merged 5 commits intoenvoyproxy:masterfrom Nov 11, 2020
Merged
Conversation
This patch makes the v2 xDS API fatal-by-default. It's possible to still use v2 by: * Providing --bootstrap-version 2 on the CLI for v2 bootstrap files. * Setting envoy.reloadable_features.enable_deprecated_v2_api in the runtime. Many tests required fixups: * Unit tests were either upgraded to v3 (where there was no significant reason to remain v2) or a test runtime was introduced permitting v2 for deprecated feature tests. * Integration tests were generally migrated to v3. This now means that our integration tests coverage focuses on v3 (it was previously focused on v2). We have some limited v2 coverage still provided by the v2 ads_integration_tests. Risk level: High (this will break anyone who is still using v2 and has not enabled CLI or runtime override) Testing: Various tests updated as described above. New unit test added for bootstrap to server_test and to ads_integration_test for dynamic rejection behavior. Release Notes: Added. Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
requested review from
PiotrSikora,
alyssawilk,
asraa,
dio,
ggreenway,
junr03,
lizan,
mattklein123,
snowp and
zuercher
as code owners
Member
|
Looks like legit CI issues. /wait |
Member
Author
|
@mattklein123 this requires envoyproxy/envoy-filter-example#137 to merge, if you can approve that I'll update the SHA. |
Signed-off-by: Harvey Tuch <htuch@google.com>
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Epic slog. One question.
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Member
Author
|
@mattklein123 @lizan is the clang-tidy timeout due to the size of this PR? |
Member
Author
|
Force merging as discussed with maintainers. |
htuch
pushed a commit
that referenced
this pull request
Nov 25, 2020
Follow up to #13950 Commit Message: kafka: fix broker integration test Additional Description: fixes manually executed kafka integration test; started to crash due to using now-fatal v2 config AFACT Risk Level: Low Testing: manual; bazel test //test/extensions/filters/network/kafka/broker/integration_test:kafka_broker_integration_test Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Dec 1, 2020
This is a followup to envoyproxy#13950 in which the transport API is also fatal-by-default. Risk level: High (this will break anyone who is still using v2 and has not enabled CLI or runtime override) Testing: Various tests updated as described above. New unit test added for bootstrap to server_test and to ads_integration_test for dynamic rejection behavior. api_version_integration_test continues to provide the definitive cross-version transport API integration test. Release Notes: Same as envoyproxy#13950. Signed-off-by: Harvey Tuch <htuch@google.com>
5 tasks
htuch
added a commit
that referenced
this pull request
Dec 7, 2020
This is a followup to #13950 in which the transport API is also fatal-by-default. Risk level: High (this will break anyone who is still using v2 and has not enabled CLI or runtime override) Testing: Various tests updated as described above. New unit test added for bootstrap to server_test and to ads_integration_test for dynamic rejection behavior. api_version_integration_test continues to provide the definitive cross-version transport API integration test. Release Notes: Same as #13950. Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Dec 14, 2020
This is a followup to envoyproxy#14223, covering remaining uses of the transport_api_version field. Risk level: High (this will break anyone who is still using v2 and has not enabled CLI or runtime override) Testing: Various tests updated, some exemplar tests added to server_test. Release Notes: Same as envoyproxy#13950. Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
added a commit
that referenced
this pull request
Dec 15, 2020
This is a followup to #14223, covering remaining uses of the transport_api_version field. Risk level: High (this will break anyone who is still using v2 and has not enabled CLI or runtime override) Testing: Various tests updated, some exemplar tests added to server_test. Release Notes: Same as #13950. Signed-off-by: Harvey Tuch <htuch@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes the v2 xDS API fatal-by-default. It's possible to still
use v2 by:
runtime.
Many tests required fixups:
reason to remain v2) or a test runtime was introduced permitting v2
for deprecated feature tests.
our integration tests coverage focuses on v3 (it was previously
focused on v2). We have some limited v2 coverage still provided by the
v2 ads_integration_tests.
Coverage remains stable, it was previously:
Overall coverage rate:
lines......: 96.6% (112119 of 116035 lines)
functions..: 79.8% (22543 of 28259 functions)
and is now:
Overall coverage rate:
lines......: 96.6% (112162 of 116096 lines)
functions..: 79.8% (22542 of 28257 functions)
Risk level: High (this will break anyone who is still using v2 and has
not enabled CLI or runtime override)
Testing: Various tests updated as described above. New unit test added
for bootstrap to server_test and to ads_integration_test for dynamic
rejection behavior.
Release Notes: Added.
Fixes #10816
Signed-off-by: Harvey Tuch htuch@google.com