config: v2 non-pubsub transport API fatal-by-default.#14389
Merged
htuch merged 4 commits intoenvoyproxy:masterfrom Dec 15, 2020
Merged
config: v2 non-pubsub transport API fatal-by-default.#14389htuch merged 4 commits intoenvoyproxy:masterfrom
htuch merged 4 commits intoenvoyproxy:masterfrom
Conversation
This is a followup to envoyproxy#14223, covering remaining uses of the transport_api_version field. Risk level: High (this will break anyone who is still using v2 and has not enabled CLI or runtime override) Testing: Various tests updated, some exemplar tests added to server_test. Release Notes: Same as envoyproxy#13950. Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
dio
reviewed
Dec 14, 2020
dio
reviewed
Dec 14, 2020
| static envoy::config::core::v3::ApiVersion | ||
| getAndCheckTransportVersion(const Proto& api_config_source) { | ||
| const auto transport_api_version = api_config_source.transport_api_version(); | ||
| if (transport_api_version == envoy::config::core::v3::ApiVersion::AUTO || |
Member
There was a problem hiding this comment.
Not sure if people will argue that "AUTO" should automatically use the currently "stable" version. But I agree that being explicit is great.
Signed-off-by: Harvey Tuch <htuch@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #14223, covering remaining uses of the
transport_api_version field.
Risk level: High (this will break anyone who is still using v2 and has
not enabled CLI or runtime override)
Testing: Various tests updated, some exemplar tests added to
server_test.
Release Notes: Same as #13950.
Signed-off-by: Harvey Tuch htuch@google.com