Skip to content

kafka: fix broker integration test#14177

Merged
htuch merged 1 commit intoenvoyproxy:masterfrom
adamkotwasinski:fix-kafka-broker-inttest
Nov 25, 2020
Merged

kafka: fix broker integration test#14177
htuch merged 1 commit intoenvoyproxy:masterfrom
adamkotwasinski:fix-kafka-broker-inttest

Conversation

@adamkotwasinski
Copy link
Contributor

Follow up to #13950

Commit Message: kafka: fix broker integration test
Additional Description: fixes manually executed kafka integration test; started to crash due to using now-fatal v2 config AFACT
Risk Level: Low
Testing: manual; bazel test //test/extensions/filters/network/kafka/broker/integration_test:kafka_broker_integration_test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
@adamkotwasinski
Copy link
Contributor Author

/review @htuch

Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit b5f6621 into envoyproxy:master Nov 25, 2020
@adamkotwasinski adamkotwasinski deleted the fix-kafka-broker-inttest branch November 25, 2020 22:02
@adamkotwasinski adamkotwasinski restored the fix-kafka-broker-inttest branch November 26, 2020 08:42
@adamkotwasinski adamkotwasinski deleted the fix-kafka-broker-inttest branch November 26, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants