formatter: use absl instead of std#13040
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Sep 9, 2020
Merged
Conversation
Signed-off-by: Michael Rebello <me@michaelrebello.com>
ggreenway
approved these changes
Sep 9, 2020
mattklein123
approved these changes
Sep 9, 2020
| JsonFormatMapVisitor visitor{json_format_map_callback, providers_callback}; | ||
| for (const auto& pair : *format.value_) { | ||
| ProtobufWkt::Value value = std::visit(visitor, pair.second); | ||
| ProtobufWkt::Value value = absl::visit(visitor, pair.second); |
Member
There was a problem hiding this comment.
Can you add a linter for this also? Feel free to do this in a follow up.
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Sep 14, 2020
Bumping primarily to include the changes from envoyproxy/envoy#12477 for decompressor trailers reporting. Contains changes to fix compilation after: - envoyproxy/envoy@d245c02 - envoyproxy/envoy@52ec66f Also contains new fixes required by Envoy Mobile: - envoyproxy/envoy#13039 - envoyproxy/envoy#13040 Signed-off-by: Michael Rebello <me@michaelrebello.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Bumping primarily to include the changes from #12477 for decompressor trailers reporting. Contains changes to fix compilation after: - d245c02 - 52ec66f Also contains new fixes required by Envoy Mobile: - #13039 - #13040 Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Bumping primarily to include the changes from #12477 for decompressor trailers reporting. Contains changes to fix compilation after: - d245c02 - 52ec66f Also contains new fixes required by Envoy Mobile: - #13039 - #13040 Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a compilation issue with Envoy Mobile on iOS caused by usage of
std::rather thanabsl::introduced in 9d466c7, which is unavailable on iOS 11.Past discussion of this issue: #12341 (comment)
cc @Pchelolo
Risk Level: Low
Testing: CI
Docs Changes: None
Signed-off-by: Michael Rebello me@michaelrebello.com