Disable signal handler tests under ASAN.#1076
Merged
mattklein123 merged 12 commits intoenvoyproxy:masterfrom Jun 12, 2017
Merged
Disable signal handler tests under ASAN.#1076mattklein123 merged 12 commits intoenvoyproxy:masterfrom
mattklein123 merged 12 commits intoenvoyproxy:masterfrom
Conversation
mattklein123
reviewed
Jun 9, 2017
ci/ci_steps.sh
Outdated
Member
There was a problem hiding this comment.
(ignore the fancy github text replacement)
Contributor
Author
There was a problem hiding this comment.
Thanks for the much needed pointer, I was thinking this was what was reported from the "docker images" command which obviously it is not.
Member
There was a problem hiding this comment.
If there are dev docs that would have made sense here please add them.
Some specific ones already had to be disabled but other tests no longer pass under the latest Clang ASAN because they mysteriously have no output. The ENVOY_BUILD_SHA is updated to the latest so CI uses that CI image.
dnoe
force-pushed
the
disable_signals_tests_under_asan
branch
from
046a721 to
b844428
Compare
mattklein123
previously approved these changes
Jun 9, 2017
Looks like Bazel 0.5.1 caused the .gcda to appear under runfiles, which confuses gcov as it doesn't match the location of the .gcno.
dnoe
commented
Jun 9, 2017
| @@ -1,5 +1,5 @@ | |||
| #!/bin/bash | |||
| ENVOY_BUILD_SHA=fc747b3c2fd49b1260484572071fe4194cd6824d | |||
| ENVOY_BUILD_SHA=1d2a2100708d1012cd61054ce04d4dc4e3b03ff2 | |||
Contributor
Author
There was a problem hiding this comment.
This change has no effect outside of this PR until it is merged, correct?
Member
There was a problem hiding this comment.
Yes, that is correct. But it's failing due to changes in bazel per the other open PR. See the comments there.
Member
…ls_tests_under_asan
Contributor
Author
|
Trying it out now. |
Contributor
Author
|
With @htuch 's change to fix coverage merged I can see an actual coverage report now. The report is not affected by my change (which only changes behavior under ASAN) but is 97.9% :( Investigating to see if something else changed. |
This commit adds a test which manually exercises the signal handler code in SignalAction. This code was previously exercised but this is a quick and dirty trick to make sure code coverage analysis picks it up by using a nonfatal signal type. Code coverage sits at 98% with this commit.
mattklein123
approved these changes
Jun 12, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Bumping primarily to include the changes from #12477 for decompressor trailers reporting. Contains changes to fix compilation after: - d245c02 - 52ec66f Also contains new fixes required by Envoy Mobile: - #13039 - #13040 Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Bumping primarily to include the changes from #12477 for decompressor trailers reporting. Contains changes to fix compilation after: - d245c02 - 52ec66f Also contains new fixes required by Envoy Mobile: - #13039 - #13040 Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
nezdolik
pushed a commit
to nezdolik/envoy
that referenced
this pull request
May 4, 2024
rsp is not actually clobbered by that code and later gccs actually (correctly) bark at it. Fixed issue envoyproxy#1076.
nezdolik
pushed a commit
to nezdolik/envoy
that referenced
this pull request
May 4, 2024
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Description** This parses OpenAI Web Tool requests and obfuscation used in gpt-5. As a part of this, we re-record all the affected requests. **Related Issues/PRs (if applicable)** #1068 --------- Signed-off-by: Adrian Cole <adrian@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some specific ones already had to be disabled but other tests no longer
pass under the latest Clang ASAN because they mysteriously have no output.
The ENVOY_BUILD_SHA is updated to the latest so CI uses that CI image.