Conversation
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Contributor
Author
|
Blocked on envoyproxy/envoy#13039 and envoyproxy/envoy#13040 |
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Contributor
Author
|
Unfortunately we have to bump the size job again: #1078 |
Contributor
|
Small ask: let's hold off on merging this while we establish a clearer signal on the crash fixes, just to avoid introducing extra variables. Thanks for prepping the update though! |
Contributor
Author
|
That's fine with me @goaway. |
rebello95
added a commit
that referenced
this pull request
Sep 11, 2020
The most recent Envoy bump requires this: #1076 ``` The new binary is 2.00 % different in size compared to main. The new binary is 5790759 bytes. The current size (5790759) is larger than the maximum size (5700000). ``` Signed-off-by: Michael Rebello <me@michaelrebello.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 28, 2022
The most recent Envoy bump requires this: envoyproxy/envoy-mobile#1076 ``` The new binary is 2.00 % different in size compared to main. The new binary is 5790759 bytes. The current size (5790759) is larger than the maximum size (5700000). ``` Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
The most recent Envoy bump requires this: envoyproxy/envoy-mobile#1076 ``` The new binary is 2.00 % different in size compared to main. The new binary is 5790759 bytes. The current size (5790759) is larger than the maximum size (5700000). ``` Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumping primarily to include the changes from envoyproxy/envoy#12477 for decompressor trailers reporting.
Contains changes to fix compilation after:
Also contains new fixes required by Envoy Mobile:
Signed-off-by: Michael Rebello me@michaelrebello.com