Skip to content

ci: switch to differentiated thirdparty_build for opt/dbg.#1224

Merged
htuch merged 2 commits intoenvoyproxy:masterfrom
htuch:thirdparty-build-sds-test
Jul 7, 2017
Merged

ci: switch to differentiated thirdparty_build for opt/dbg.#1224
htuch merged 2 commits intoenvoyproxy:masterfrom
htuch:thirdparty-build-sds-test

Conversation

@htuch
Copy link
Member

@htuch htuch commented Jul 7, 2017

As per #1223.

mattklein123
mattklein123 previously approved these changes Jul 7, 2017
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well hacked

@mattklein123
Copy link
Member

Per offline convo the format issue is because the new CI image picked up a new version of clang-format-5.0. If this becomes too much of a shitshow we are going to have to use clang-format-4.0.

@htuch htuch closed this Jul 7, 2017
@htuch htuch reopened this Jul 7, 2017
@htuch
Copy link
Member Author

htuch commented Jul 7, 2017

Kicking travis, bazel.release timed out.

@htuch htuch merged commit 09629dc into envoyproxy:master Jul 7, 2017
@htuch htuch deleted the thirdparty-build-sds-test branch July 7, 2017 18:49
jpsim pushed a commit that referenced this pull request Nov 28, 2022
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants