docs: clarify xcode reqs for macOS build#11977
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Jul 13, 2020
Merged
docs: clarify xcode reqs for macOS build#11977mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
LisaLudique
reviewed
Jul 9, 2020
Contributor
LisaLudique
left a comment
LisaLudique
left a comment
There was a problem hiding this comment.
thanks for clarifying the docs! it may also be worth updating https://github.com/envoyproxy/envoy/blob/8d7cd0c61659a2dee0e6527de2c624ada8d2e12b/ci/README.md#macos-build-flow
zuercher
previously approved these changes
Jul 9, 2020
Contributor
Author
|
Updated the mac CI instructions too! |
Member
|
#12018 is merged. Please sync your branch with head to fix the CI (Linux-x64 asan) issue. Thanks! |
Signed-off-by: Garrett Heel <garrettheel@users.noreply.github.com>
Member
|
I've rerun that test several times and it keeps hitting #9784. Can someone in @envoyproxy/admins by-pass the checks and merge this docs only change? |
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
Signed-off-by: Garrett Heel <garrettheel@users.noreply.github.com> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Clarify the version of Xcode required to build envoy on macOS
Additional Description: I incorrectly assumed that the Xcode Command Line Tools would be sufficient here, but that was not the case.
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A