Skip to content

docs: fix grammar in outlier detection doc#11971

Merged
htuch merged 1 commit intoenvoyproxy:masterfrom
numerodix:doc-fixes-outlier-detection
Jul 9, 2020
Merged

docs: fix grammar in outlier detection doc#11971
htuch merged 1 commit intoenvoyproxy:masterfrom
numerodix:doc-fixes-outlier-detection

Conversation

@numerodix
Copy link
Contributor

Commit Message: docs: fix grammar in outlier detection doc
Additional Description: Fixes grammar errors and does minor rephrasing to improve how the Outlier detection architecture doc reads.
Risk Level: low
Testing: N/A
Docs Changes: grammar
Release Notes: N/A

Signed-off-by: Martin Matusiak numerodix@gmail.com

@numerodix
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

🤷‍♀️ nothing to rebuild.

🐱

Caused by: a #11971 (comment) was created by @numerodix.

see: more, trace.

Copy link
Member

@ggreenway ggreenway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the docs improvement! A few spelling errors, but other than that this is great.

Copy link
Member

@ggreenway ggreenway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh. Github allowed me to fix the spelling, but somehow that ran afoul of the DCO bot.

Can you please squash the 4 commits and force-push to this branch? I think this is ready to merge after that.

@ggreenway ggreenway self-assigned this Jul 9, 2020
Fixes grammar errors and does minor rephrasing to improve how
the Outlier detection architecture doc reads.

Signed-off-by: Martin Matusiak <numerodix@gmail.com>
Signed-off-by: Greg Greenway <ggreenway@apple.com>
@numerodix numerodix force-pushed the doc-fixes-outlier-detection branch from 5011688 to 6e3bfae Compare July 9, 2020 20:46
@numerodix
Copy link
Contributor Author

Thanks for fixing the spelling errors, @ggreenway !

Squashed and forced pushed.

Copy link
Member

@ggreenway ggreenway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the spelling errors, @ggreenway !

Squashed and forced pushed.

Thanks! Sorry for the DCO trouble.

@ggreenway
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@numerodix
Copy link
Contributor Author

asan failed again, but now azure says "build not found" 😕

Earlier it was failing over a file not found:

2020-07-09T22:27:05.3062969Z ls: cannot access '/tmp/tap//tap_*.pb_text': No such file or directory

Same failure mode as #11977

@htuch htuch merged commit 8e006eb into envoyproxy:master Jul 9, 2020
scheler pushed a commit to scheler/envoy that referenced this pull request Aug 4, 2020
Fixes grammar errors and does minor rephrasing to improve how the Outlier detection architecture doc reads.

Risk Level: low
Testing: N/A
Docs Changes: grammar
Release Notes: N/A

Signed-off-by: Martin Matusiak <numerodix@gmail.com>
Signed-off-by: scheler <santosh.cheler@appdynamics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants