Skip to content

Disable signal handler tests under ASAN. #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 12 commits into from
Jun 12, 2017
Merged

Disable signal handler tests under ASAN. #1076

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b844428
Disable signal handler tests under ASAN.
dnoe Jun 9, 2017
f17a82a
Fix Bazel coverage.
htuch Jun 9, 2017
9e90588
Some debug stuff
htuch Jun 11, 2017
1ef5686
Bump ENVOY_BUILD_SHA to 1d2a2100708d1012cd61054ce04d4dc4e3b03ff2
htuch Jun 11, 2017
eeef5f7
Switch to dbg builds always, with NDEBUG set.
htuch Jun 11, 2017
e3f1893
Remove debug.
htuch Jun 11, 2017
be7bc6b
Revert ENVOY_BUILD_SHA, more debug.
htuch Jun 11, 2017
6d1f49f
Redo ENVOY_BUILD_SHA, we definitely need this for the fix.
htuch Jun 11, 2017
4fd34ca
fix
htuch Jun 11, 2017
3bc0104
Remove debug.
htuch Jun 11, 2017
3d9b336
Merge remote-tracking branch 'htuch/fix-bazel-cov' into disable_signa…
dnoe Jun 12, 2017
11d8975
Manually call signal handler in test.
dnoe Jun 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/ci_steps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
ENVOY_BUILD_SHA=fc747b3c2fd49b1260484572071fe4194cd6824d
ENVOY_BUILD_SHA=1d2a2100708d1012cd61054ce04d4dc4e3b03ff2

@dnoe dnoe Jun 9, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has no effect outside of this PR until it is merged, correct?

@mattklein123 mattklein123 Jun 10, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is correct. But it's failing due to changes in bazel per the other open PR. See the comments there.


# Script that lists all the steps take by the CI system when doing Envoy builds.
set -e
Expand Down
10 changes: 5 additions & 5 deletions test/exe/signals_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ namespace Envoy {
#define ASANITIZED /* Sanitized by GCC */
#endif

// Memory violation signal tests are disabled under address sanitizer. The
// sanitizer does its own special signal handling and prints messages that are
// not ours instead of what this test expects. The signals special handled by ASAN
// include SIGSEGV, SIGBUS, and SIGFPE.
// Death tests that expect a particular output are disabled under address sanitizer.
// The sanitizer does its own special signal handling and prints messages that are
// not ours instead of what this test expects. As of latest Clang this appears
// to include abort() as well.
#ifndef ASANITIZED
TEST(Signals, InvalidAddressDeathTest) {
SignalAction actions;
Expand Down Expand Up @@ -52,7 +52,6 @@ TEST(Signals, BadMathDeathTest) {
raise(SIGFPE);
}(), "backtrace.*Floating point");
}
#endif

#if defined(__x86_64__) || defined(__i386__)
// Unfortunately we don't have a reliable way to do this on other platforms
Expand Down Expand Up @@ -81,6 +80,7 @@ TEST(Signals, RestoredPreviousHandlerDeathTest) {
// Outer SignalAction should be active again:
EXPECT_DEATH([]() -> void { abort(); }(), "backtrace.*Aborted");
}
#endif

TEST(Signals, IllegalStackAccessDeathTest) {
SignalAction actions;
Expand Down