Merged
Conversation
rebello95
reviewed
Sep 11, 2019
rebello95
added a commit
that referenced
this pull request
Sep 11, 2019
`Client` -> `HTTPClient` `Envoy` -> `EnvoyClient` `EnvoyBuilder` -> `EnvoyClientBuilder` Consistent with [this Android change](#424), and helps us to avoid naming collisions with the `Envoy` type and `Envoy` module namespace. Signed-off-by: Michael Rebello <me@michaelrebello.com>
rebello95
previously approved these changes
Sep 11, 2019
rebello95
added a commit
that referenced
this pull request
Sep 11, 2019
`Client` -> `HTTPClient` `Envoy` -> `EnvoyClient` `EnvoyBuilder` -> `EnvoyClientBuilder` Consistent with [this Android change](#424), and helps us to avoid naming collisions with the `Envoy` type and `Envoy` module namespace. Signed-off-by: Michael Rebello <me@michaelrebello.com>
added 2 commits
September 11, 2019 13:46
Signed-off-by: Alan Chiu <achiu@lyft.com>
buildbreaker
force-pushed
the
rename-envoy-to-envoyclient
branch
from
6d15241 to
a4ce1b0
Compare
rebello95
approved these changes
Sep 11, 2019
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 28, 2022
`Client` -> `HTTPClient` `Envoy` -> `EnvoyClient` `EnvoyBuilder` -> `EnvoyClientBuilder` Consistent with [this Android change](envoyproxy/envoy-mobile#424), and helps us to avoid naming collisions with the `Envoy` type and `Envoy` module namespace. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
`Client` -> `HTTPClient` `Envoy` -> `EnvoyClient` `EnvoyBuilder` -> `EnvoyClientBuilder` Consistent with [this Android change](envoyproxy/envoy-mobile#424), and helps us to avoid naming collisions with the `Envoy` type and `Envoy` module namespace. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alan Chiu achiu@lyft.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Rename Envoy to EnvoyClient
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]