Skip to content

docs: release notes and unhide fields for IP_FREEBIND support. #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 3 commits into from
Mar 29, 2018
Merged

docs: release notes and unhide fields for IP_FREEBIND support. #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a0b123
docs: release notes and unhide fields for IP_FREEBIND support.
htuch Mar 28, 2018
5fa3723
Merge remote-tracking branch 'upstream/master' into freebind-release-…
htuch Mar 29, 2018
935994f
Fix format.
htuch Mar 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/root/intro/version_history.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ Version history
* logger: all :ref:`logging levels <operations_admin_interface_logging>` can be configured
at run-time: trace debug info warning error critical.
* logger: added the ability to optionally set the log format via the :option:`--log-format` option.
* sockets: added `IP_FREEBIND` socket option support for :ref:`listeners
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 Mar 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you are in here and have to make a format change, can you move your round robin change to under "load balancer" (or whatever we use below)?

Copy link
Copy Markdown
Member Author

@htuch htuch Mar 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do this in #579, where I'm also adding a load balancer entry.

<envoy_api_field_Listener.freebind>` and upstream connections via
:ref:`cluster manager wide
<envoy_api_field_config.bootstrap.v2.ClusterManager.upstream_bind_config>` and
:ref:`cluster specific <envoy_api_field_Cluster.upstream_bind_config>` options.
* tracing: the sampling decision is now delegated to the tracers, allowing the tracer to decide when and if
to use it. For example, if the :ref:`x-b3-sampled <config_http_conn_man_headers_x-b3-sampled>` header
is supplied with the client request, its value will override any sampling decision made by the Envoy proxy.
Expand Down
14 changes: 7 additions & 7 deletions envoy/api/v2/core/address.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,13 @@ message BindConfig {
SocketAddress source_address = 1
[(validate.rules).message.required = true, (gogoproto.nullable) = false];

// [#not-implemented-hide:] Whether to set the *IP_FREEBIND* option when
// creating the socket. When this flag is set to true, allows the
// :ref:`source_address <envoy_api_field_UpstreamBindConfig.source_address>`
// to be an IP address that is not configured on the system running Envoy.
// When this flag is set to false, the option *IP_FREEBIND* is disabled on the
// socket. When this flag is not set (default), the socket is not modified,
// i.e. the option is neither enabled nor disabled.
// Whether to set the *IP_FREEBIND* option when creating the socket. When this
// flag is set to true, allows the :ref:`source_address
// <envoy_api_field_UpstreamBindConfig.source_address>` to be an IP address
// that is not configured on the system running Envoy. When this flag is set
// to false, the option *IP_FREEBIND* is disabled on the socket. When this
// flag is not set (default), the socket is not modified, i.e. the option is
// neither enabled nor disabled.
google.protobuf.BoolValue freebind = 2;
}

Expand Down
12 changes: 6 additions & 6 deletions envoy/api/v2/lds.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,11 @@ message Listener {
// is neither set nor reset.
google.protobuf.BoolValue transparent = 10;

// [#not-implemented-hide:] Whether the listener should set the *IP_FREEBIND*
// socket option. When this flag is set to true, listeners can be bound to an
// IP address that is not configured on the system running Envoy. When this
// flag is set to false, the option *IP_FREEBIND* is disabled on the socket.
// When this flag is not set (default), the socket is not modified, i.e. the
// option is neither enabled nor disabled.
// Whether the listener should set the *IP_FREEBIND* socket option. When this
// flag is set to true, listeners can be bound to an IP address that is not
// configured on the system running Envoy. When this flag is set to false, the
// option *IP_FREEBIND* is disabled on the socket. When this flag is not set
// (default), the socket is not modified, i.e. the option is neither enabled
// nor disabled.
google.protobuf.BoolValue freebind = 11;
}