docs: release notes and unhide fields for locality based balancing.#579
docs: release notes and unhide fields for locality based balancing.#579htuch merged 7 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
changed the title
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
So I think our policy on ordering is to not unhide until the code is in. Should we defer LGTMs on the assumption someone will likely auto-merge once it's approved or LGTM right away and be more careful on merges?
docs/root/intro/version_history.rst
Outdated
| <arch_overview_load_balancing_types_round_robin>` support. The round robin | ||
| scheduler now respects endpoint weights and also has improved fidelity across | ||
| picks. | ||
| * :ref:`Locality weighted load balancing <arch_overview_load_balancer_subsets>` |
There was a problem hiding this comment.
Prior release notes are in the form
component: description
If we're sticking with that, can you update this and the round robin one to be prefaced with "loadbalancing:" ?
It'll also help with merge if we update components rather than just add things to the bottom
htuch
changed the title
|
@alyssawilk I think the idea is that when an implementation PR goes up in the main repo, we stage the docs/release notes change here. We defer the merge until after the implementation PR merges. |
htuch
changed the title
Signed-off-by: Harvey Tuch <htuch@google.com>
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
In that case you may have your LGTM, sir. I'll trust you to merge when you ought to.
Besides, even odds you'll have a merge conflict and have to re-sync by then.
Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM, but needs some CI fixes.
3 participants
See envoyproxy/envoy#2892.