Skip to content

docs: release notes and unhide fields for IP_FREEBIND support.#588

Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
htuch:freebind-release-notes
Mar 29, 2018
Merged

docs: release notes and unhide fields for IP_FREEBIND support.#588
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
htuch:freebind-release-notes

Conversation

@htuch
Copy link
Copy Markdown
Member

@htuch htuch commented Mar 28, 2018

Corresponding PR envoyproxy/envoy#2922.

Signed-off-by: Harvey Tuch htuch@google.com

Corresponding PR envoyproxy/envoy#2922.

Signed-off-by: Harvey Tuch <htuch@google.com>
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small ask.

* logger: all :ref:`logging levels <operations_admin_interface_logging>` can be configured
at run-time: trace debug info warning error critical.
* logger: added the ability to optionally set the log format via the :option:`--log-format` option.
* sockets: added `IP_FREEBIND` socket option support for :ref:`listeners
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you are in here and have to make a format change, can you move your round robin change to under "load balancer" (or whatever we use below)?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do this in #579, where I'm also adding a load balancer entry.

htuch added 2 commits March 29, 2018 10:15
Signed-off-by: Harvey Tuch <htuch@google.com>
@mattklein123 mattklein123 merged commit fc5a03d into envoyproxy:master Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants