Skip to content

Add *_headers_to_add to ClusterWeight #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 3 commits into from
Jan 30, 2018
Merged

Add *_headers_to_add to ClusterWeight #441

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b4c64a
Add *_header_to_add to `ClusterWeight`
mandarjog Jan 28, 2018
7d2e4bf
Add not-implemented-hide on new options
mandarjog Jan 29, 2018
fe2dae9
Add response_headers_to_remove
mandarjog Jan 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions envoy/api/v2/route/route.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,26 @@ message WeightedCluster {
// cluster with metadata matching that set in metadata_match will be
// considered. The filter name should be specified as *envoy.lb*.
Metadata metadata_match = 3;

// Specifies a list of headers to be added to requests when this cluster is selected

@mattklein123 mattklein123 Jan 29, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the not implemented tags unless the associated Envoy PR is going to get posted at the same time.

// through the enclosing :ref:`envoy_api_msg_route.RouteAction`.
// Headers specified at this level are applied before headers from the enclosing
// :ref:`envoy_api_msg_route.RouteAction`,
// :ref:`envoy_api_msg_route.VirtualHost`, and
// :ref:`envoy_api_msg_route.RouteConfiguration`. For more information, including details on
// header value syntax, see the documentation on :ref:`custom request headers
// <config_http_conn_man_headers_custom_request_headers>`.
repeated HeaderValueOption request_headers_to_add = 4;

// Specifies a list of headers to be added to responses when this cluster is selected
// through the enclosing :ref:`envoy_api_msg_route.RouteAction`.
// Headers specified at this level are applied before headers from the enclosing
// :ref:`envoy_api_msg_route.RouteAction`,
// :ref:`envoy_api_msg_route.VirtualHost`, and
// :ref:`envoy_api_msg_route.RouteConfiguration`. For more information, including details on
// header value syntax, see the documentation on :ref:`custom request headers
// <config_http_conn_man_headers_custom_request_headers>`.
repeated HeaderValueOption response_headers_to_add = 5;

@zuercher zuercher Jan 29, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we go ahead an put response_headers_to_remove in here?

@mattklein123 mattklein123 Jan 29, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 might as well be consistent

@mandarjog mandarjog Jan 30, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added response_headers_to_remove

Now it feels like it should be a separate proto, there is plenty of repetition in this file.

message HeaderAction {
   repeated HeaderValueOption request_headers_to_add = 1;
   repeated HeaderValueOption response_headers_to_add = 2;
   repeated string response_headers_to_remove = 3;
}

@htuch htuch Jan 30, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we can't refactor, as the other locations that this occurs in are frozen.

}

// Specifies one or more upstream clusters associated with the route.
Expand Down