Add *_headers_to_add to ClusterWeight#441
Conversation
Add request_headers_to_add and response_headers_to_add to ClusterWeight. Signed-off-by: Mandar U Jog <mjog@google.com>
|
/cc @zuercher |
| // considered. The filter name should be specified as *envoy.lb*. | ||
| Metadata metadata_match = 3; | ||
|
|
||
| // Specifies a list of headers to be added to requests when this cluster is selected |
There was a problem hiding this comment.
Please add the not implemented tags unless the associated Envoy PR is going to get posted at the same time.
Signed-off-by: Mandar U Jog <mjog@google.com>
|
@htuch @mattklein123 Added |
|
LGTM. Holding until the refactor is merged. |
| // :ref:`envoy_api_msg_route.RouteConfiguration`. For more information, including details on | ||
| // header value syntax, see the documentation on :ref:`custom request headers | ||
| // <config_http_conn_man_headers_custom_request_headers>`. | ||
| repeated HeaderValueOption response_headers_to_add = 5; |
There was a problem hiding this comment.
Should we go ahead an put response_headers_to_remove in here?
There was a problem hiding this comment.
+1 might as well be consistent
There was a problem hiding this comment.
Added response_headers_to_remove
Now it feels like it should be a separate proto, there is plenty of repetition in this file.
message HeaderAction {
repeated HeaderValueOption request_headers_to_add = 1;
repeated HeaderValueOption response_headers_to_add = 2;
repeated string response_headers_to_remove = 3;
}There was a problem hiding this comment.
Unfortunately, we can't refactor, as the other locations that this occurs in are frozen.
|
Also, |
Signed-off-by: Mandar U Jog <mjog@google.com>
mandarjog
force-pushed
the
header_to_add
branch
from
1ddc30f to
fe2dae9
Compare
|
@zuercher I will update |
|
@mattklein123 can this move forward now, #438 has merged. |
…clusters (#2765) Implements the request_headers_to_add, response_headers_to_add, and response_headers_to_remove fields added to weighted clusters by envoyproxy/data-plane-api#441. Risk Level: Low - no change in behavior without configuration changes Testing: unit and integration tests Docs Changes: envoyproxy/data-plane-api#531 Release Notes: updated Fixes: #2455 Signed-off-by: Stephan Zuercher stephan@turbinelabs.io
4 participants
Add request_headers_to_add and response_headers_to_add to ClusterWeight.
The directives are processed when the cluster in selected through the enclosing RouteAction.
reference: envoyproxy/envoy#2455
Signed-off-by: Mandar U Jog mjog@google.com