Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Move buildId to latest #2333

Merged
merged 1 commit into from
Jan 23, 2023
Merged

[Windows] Move buildId to latest #2333

merged 1 commit into from
Jan 23, 2023

Conversation

marcwrobel
Copy link
Member

@marcwrobel marcwrobel commented Jan 20, 2023

See also #2296 and #2340.

@marcwrobel marcwrobel changed the title [Windows] Move buildId to latest [Windows] Move buildId to latest Jan 20, 2023
@Evernow
Copy link
Contributor

Evernow commented Jan 20, 2023

I'm personally against this sort of change that very obviously breaks how others may be using the API already, as it renames buildId, especially as I see no benefit to the end user.

@captn3m0
Copy link
Member

The API is still in Alpha, so we can make breaking changes. Moreover, the stability guarantee shouldn't apply to products themselves, just the overall API - we should be allowed to make changes like dropping codenames, or adding/removing columns for products still.

buildId was added in the API around October in #1651, the field used cycleShortHand earlier (which was also incorrect, imo).

+1 to just switching to latest, since that makes it the most clear and usable.

@marcwrobel
Copy link
Member Author

I'm personally against this sort of change that very obviously breaks how others may be using the API already, as it renames buildId, especially as I see no benefit to the end user.

I understand your point about breaking the API, really. It's a pain in the a** when API definition changes. This is why we had requests for API versioning (#2331, #2066) and I hope we will go in the right direction with #2080 (do not hesitate to give me your feedback on this PR @Evernow !).

But I do not agree with the I see no benefit to the end user part because:

So I think it makes things go in the right direction, but unfortunately it breaks things for API users. But hopefully it was made available in the API quite recently and we are still in alpha.

@marcwrobel marcwrobel marked this pull request as ready for review January 21, 2023 09:54
@marcwrobel
Copy link
Member Author

PR ready for review.

Copy link
Member

@usta usta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove /en-us/ or /fr-fr/ parts in url , website will relocate user to its language directly

@marcwrobel
Copy link
Member Author

Please remove /en-us/ or /fr-fr/ parts in url , website will relocate user to its language directly

Done. Sorry I missed it.

@marcwrobel marcwrobel requested a review from usta January 22, 2023 11:40
@captn3m0
Copy link
Member

captn3m0 commented Jan 22, 2023 via email

@marcwrobel
Copy link
Member Author

LGTM. We should look at automating this next.

Yep, but it would be difficult for the time being. I did not find any "centralized" source of Windows releases (except maybe Wikipedia) and anyway we are only tracking the buildId which looks stable (i.e. never updated).

I noticed during my search that :

Don't know what to do with those informations.

@Evernow
Copy link
Contributor

Evernow commented Jan 22, 2023

Yep, but it would be difficult for the time being. I did not find any "centralized" source of Windows releases (except maybe Wikipedia) and anyway we are only tracking the buildId which looks stable (i.e. never updated).

I tried tackling this for a personal project of mine and came to the same realization, the closest thing I found is FIDO which is a tool Rufus uses for downloading ISOs.

However there are flaws with this, such as having to parse in output that could potentially change, it having problems from time to time and it not giving exact dates.

The powershell script may have its own API you can access, but when I used to use it I parsed it using this: https://github.com/24HourSupport/CommonSoftware/blob/main/.github/workflows/fidoparser.py#L21

On a different topic, sorry forgot to respond earlier to your statement, I agree with you, this looks good to me,

marcwrobel added a commit that referenced this pull request Jan 22, 2023
@marcwrobel marcwrobel force-pushed the windows-buildid-version branch from 4770b04 to 6c33d8e Compare January 22, 2023 18:57
marcwrobel added a commit that referenced this pull request Jan 22, 2023
Copy link
Member

@usta usta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@BiNZGi BiNZGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BiNZGi BiNZGi merged commit 2ff5992 into master Jan 23, 2023
@BiNZGi BiNZGi deleted the windows-buildid-version branch January 23, 2023 08:05
@captn3m0 captn3m0 added the product-fixes Product content or release fixes that do not count as updates label Jan 23, 2023
marcwrobel added a commit that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product-fixes Product content or release fixes that do not count as updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants