-
-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Move buildId
to latest
#2333
Conversation
buildId
to latest
I'm personally against this sort of change that very obviously breaks how others may be using the API already, as it renames buildId, especially as I see no benefit to the end user. |
The API is still in Alpha, so we can make breaking changes. Moreover, the stability guarantee shouldn't apply to products themselves, just the overall API - we should be allowed to make changes like dropping codenames, or adding/removing columns for products still. buildId was added in the API around October in #1651, the field used cycleShortHand earlier (which was also incorrect, imo). +1 to just switching to |
I understand your point about breaking the API, really. It's a pain in the a** when API definition changes. This is why we had requests for API versioning (#2331, #2066) and I hope we will go in the right direction with #2080 (do not hesitate to give me your feedback on this PR @Evernow !). But I do not agree with the I see no benefit to the end user part because:
So I think it makes things go in the right direction, but unfortunately it breaks things for API users. But hopefully it was made available in the API quite recently and we are still in alpha. |
PR ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove /en-us/
or /fr-fr/
parts in url , website will relocate user to its language directly
Done. Sorry I missed it. |
LGTM. We should look at automating this next.
|
Yep, but it would be difficult for the time being. I did not find any "centralized" source of Windows releases (except maybe Wikipedia) and anyway we are only tracking the I noticed during my search that :
Don't know what to do with those informations. |
I tried tackling this for a personal project of mine and came to the same realization, the closest thing I found is FIDO which is a tool Rufus uses for downloading ISOs. However there are flaws with this, such as having to parse in output that could potentially change, it having problems from time to time and it not giving exact dates. The powershell script may have its own API you can access, but when I used to use it I parsed it using this: https://github.com/24HourSupport/CommonSoftware/blob/main/.github/workflows/fidoparser.py#L21 On a different topic, sorry forgot to respond earlier to your statement, I agree with you, this looks good to me, |
4770b04
to
6c33d8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
See also #2296 and #2340.