[sort] Sort products manually and remove sortReleasesBy #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps anyone make bulk changes to all products
|
Should be good to review now. |
|
Merging this, don't want to keep rebasing this and handle conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely removes all mentions of sorting, as based on @generalmimon's suggestion here
Fixes #1643, by getting rid of all cycleShorthand mentions as well.
The windows pages were using buildIDs for sorting via
cycleShortHand- I've renamed it tobuildIDto preserve the information for now. We can decide how/if we want to use it later.I've validated the sorting for all pages that seemed impacted, and corrected. There's some minor swaps where sorting was indeterminate (dates of two rows are matching) - I've ignored those, and let it be.
I lost some comments in the Samsung Page - wasn't sure where they needed to be added.
The sorting order is "as on the markdown file", so newer stuff should be added to the top of the file.