Skip to content

[windows][windowsserver] Add Build ID #2296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[windows][windowsserver] Add Build ID #2296

wants to merge 4 commits into from

Conversation

jlaundry
Copy link
Contributor

This PR adds the Windows build ID to release names (i.e., Windows Server 2022 (10.0.20348)), by adding the __BUILDID__ option to the releaseLabel template.

This makes it easier to lookup Windows versions and improve search results, as many system tools use the build ID instead of the version \w{4} shortname.

@usta usta changed the title Add Build ID to Windows releaseCycle [windows][windowsserver] Add Build ID Jan 16, 2023
@usta
Copy link
Member

usta commented Jan 16, 2023 via email

@jlaundry
Copy link
Contributor Author

Now this pr needs a rebase and a bit more touch for releaselabel after latest merge on windows.md file

Agreed, and done 🙂

@usta
Copy link
Member

usta commented Jan 16, 2023

hmm after thinking twice i think that (build xyz) part should be in directly in __BUILDID__ variable
so that if we got a product without its buildId it wont be look like Windows Z.Y (Build )
and we can change that
releaseLabel: "Windows __RELEASE_CYCLE__ (build __BUILDID__)"
to
releaseLabel: "Windows __RELEASE_CYCLE__ __BUILDID__"
@captn3m0 @marcwrobel i dont have ruby knowledge could you give us a hand please ? edit : i think i found how to do it :) thx anyway :)

@BiNZGi
Copy link
Member

BiNZGi commented Jan 16, 2023

In my view the build version should not be part of the releaseCycle. The build version can change with the installation of updates. I would prefer to name it like e.g. Windows 11 release information -> Latest build. In the table I would prefer to have a separate column at the end like in SQL Server.

@marcwrobel
Copy link
Member

I agree with @BiNZGi, I am more in favor of converting the buildId to a version (similar to https://endoflife.date/mssqlserver). The main reason is that buildId is only used for Windows.

Having said that there is also the releaseId (https://stackoverflow.com/questions/38935715/get-windows-10-build-version-release-id), which complicates things. I do not know which one is the most "used".

@jlaundry would it be OK for you if the buildId was in its own column ?

@BiNZGi
Copy link
Member

BiNZGi commented Jan 19, 2023

Having said that there is also the releaseId (https://stackoverflow.com/questions/38935715/get-windows-10-build-version-release-id), which complicates things. I do not know which one is the most "used".

The releaseId is already in the releaseCycle called version because the support and eol is different, e.g. 22H2 in Windows 10, version 22H2. Windows lists these details:

  • Edition, e.g. Windows 10 Pro
  • Version, e.g. 22H2
  • OS build, e.g. 19045.2486

@marcwrobel
Copy link
Member

Just gave it a shot on Windows : #2333. Is it what you imagined @BiNZGi (preview: https://deploy-preview-2333--endoflife-date.netlify.app/windows) ?

@BiNZGi
Copy link
Member

BiNZGi commented Jan 20, 2023

@marcwrobel That is indeed what I imagined 👍

@marcwrobel
Copy link
Member

@jlaundry, could you tell us if this format would suit you : https://deploy-preview-2333--endoflife-date.netlify.app/windows ?

@jlaundry
Copy link
Contributor Author

Yup, that's perfect @marcwrobel !

@marcwrobel
Copy link
Member

Ok, great. Closing this PR in favor of #2333.

@marcwrobel marcwrobel closed this Jan 21, 2023
marcwrobel added a commit that referenced this pull request Jan 22, 2023
marcwrobel added a commit that referenced this pull request Jan 22, 2023
marcwrobel added a commit that referenced this pull request Jan 22, 2023
BiNZGi pushed a commit that referenced this pull request Jan 23, 2023
marcwrobel added a commit that referenced this pull request Jan 23, 2023
@marcwrobel
Copy link
Member

@jlaundry, FYI both pages has been updated with the buildId as the latest version.

@marcwrobel marcwrobel added the product-updates Product content updates that are not fixes nor releases updates label Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product-updates Product content updates that are not fixes nor releases updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants