-
-
Notifications
You must be signed in to change notification settings - Fork 888
[windows][windowsserver] Add Build ID #2296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Now this pr needs a rebase and a bit more touch for releaselabel after
latest merge on windows.md file
…On Mon, Jan 16, 2023, 00:47 Jed Laundry ***@***.***> wrote:
This PR adds the Windows build ID to release names (i.e., *Windows Server
2022 (10.0.20348)*), by adding the __BUILDID__ option to the releaseLabel
template.
This makes it easier to lookup Windows versions and improve search
results, as many system tools use the build ID instead of the version
\w{4} shortname.
------------------------------
You can view, comment on, or merge this pull request online at:
#2296
Commit Summary
- 32d547d
<32d547d>
Add buildID to releaseLabel template
- 4f544b4
<4f544b4>
Update Windows product releaseLabel
File Changes
(3 files
<https://github.com/endoflife-date/endoflife.date/pull/2296/files>)
- *M* _plugins/product-data-enricher.rb
<https://github.com/endoflife-date/endoflife.date/pull/2296/files#diff-2cfebb47d54b2bf92f03c345cb589fed9384b692e7a54025213f020689e526af>
(1)
- *M* products/windows.md
<https://github.com/endoflife-date/endoflife.date/pull/2296/files#diff-6ab409f640cc87ca79e33ae3faf81dcce5a1aee458088eb59c553eadce039bcd>
(1)
- *M* products/windowsServer.md
<https://github.com/endoflife-date/endoflife.date/pull/2296/files#diff-a79c96da65dbb1e3dc19c9aff015af12c072706e5ff9afff0384b61b4b3af8de>
(2)
Patch Links:
- https://github.com/endoflife-date/endoflife.date/pull/2296.patch
- https://github.com/endoflife-date/endoflife.date/pull/2296.diff
—
Reply to this email directly, view it on GitHub
<#2296>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA3R4W6V7GBKSXI2BVBMTTWSRV5ZANCNFSM6AAAAAAT4CYGSY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Agreed, and done 🙂 |
hmm after thinking twice i think that (build xyz) part should be in directly in |
In my view the build version should not be part of the releaseCycle. The build version can change with the installation of updates. I would prefer to name it like e.g. Windows 11 release information -> |
I agree with @BiNZGi, I am more in favor of converting the Having said that there is also the @jlaundry would it be OK for you if the |
The
|
Just gave it a shot on Windows : #2333. Is it what you imagined @BiNZGi (preview: https://deploy-preview-2333--endoflife-date.netlify.app/windows) ? |
@marcwrobel That is indeed what I imagined 👍 |
@jlaundry, could you tell us if this format would suit you : https://deploy-preview-2333--endoflife-date.netlify.app/windows ? |
Yup, that's perfect @marcwrobel ! |
Ok, great. Closing this PR in favor of #2333. |
@jlaundry, FYI both pages has been updated with the |
This PR adds the Windows build ID to release names (i.e., Windows Server 2022 (10.0.20348)), by adding the
__BUILDID__
option to the releaseLabel template.This makes it easier to lookup Windows versions and improve search results, as many system tools use the build ID instead of the
version \w{4}
shortname.