Remove all traces of Preact from the repository#2773
Remove all traces of Preact from the repository#2773Andarist merged 4 commits intoemotion-js:mainfrom
Conversation
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 133795c:
|
| ".emotion-0 { | ||
| color: red; | ||
| } | ||
|
|
||
| .emotion-1 { | ||
| width: 100%; | ||
| } |
There was a problem hiding this comment.
It looks like those were actually working :p although I guess that there is no special handling for this in our code?
There was a problem hiding this comment.
Lol, so yes the snapshots were working, though we were on a very old version of Preact and using preact-render-to-json which is now defunct AFAIK.
I guess, bottom line is, I don't see the need for Preact tests if Emotion doesn't support Preact.
This was originally discussed here.
This PR is a stepping stone for the Yarn 3 upgrade. This is necessary because we depended on a really old version of Preact that Yarn 3 failed to install. (Yarn 3 upgrade is blocked by the website upgrade, btw. That is #2571.)
If anyone is using
@emotion/styledwith Preact, my changes toisPropValidwill break them. But I kind of doubt@emotion/styledworks with Preact in the first place so it should be fine. (?)