Conversation
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit af6d597:
|
Eh, ye - this is bizarre. It looks like webpack is trying to bundle |
|
When I looked at |
f5e4d11 to
8efaf8a
Compare
Codecov Report
|
|
This one is also a mess, and the changes were quite minimal. Just going to close this and redo it once #2571 gets merged. |
PLEASE SQUASH
This is ready for review, but not for merge. The documentation site build issue detailed below needs to be resolved before merge.
After merging or checking out these changes, I recommend deleting all
node_modulesfolders in the repository.git clean -dixis a good way to do this (deletes all ignored files).Other than just being a nice modernization change, this should make installs noticeably faster.
opencollective postinstallfrompostinstallscript since Yarn 3 doesn't actually display this output. (At least not when running locally — it would get displayed in CI. Not sure why.)yarn lint:checkfrommain.ymlworkflow.Caching in CI workflow
With the caching left virtually unchanged from how it worked with Yarn 1 (caching both
.yarn/cacheandnode_modules), workspace-related stuff went awry on Windows which you can see here: https://github.com/emotion-js/emotion/runs/5264870316.My understanding is that it is an antipattern to cache
node_modules, so I changed the caching to use the cache functionality built intoactions/setup-node. I believe this only caches.yarn/cache.This change will make the workflows a bit slower to run since each workflow must complete the linking phase of
yarn install. Is this OK? One way to reduce the number of GitHub Actions minutes we use would be to reduce the number of jobs. For example, make the dtslint job a single job instead of a matrix.Gatsby build
I cannot get the Gatsby site to build no matter what I try after this upgrade... the error is:
I think it would be easiest to just get the Next.js website PR merged into
mainfirst. That will probably cause this error to go away.