[BREAKING] Respect JOBS count if present #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
force-pushed
the
respect-jobs
branch
from
5335f6a
to
c2b1399
Compare
rwjblue
reviewed
Jun 24, 2021
lifeart
approved these changes
Jul 7, 2021
@rwjblue it's been a while now, but I believe we spoke about this after your comment, but maybe we should touch-base quick. My thoughts, without this PR we cannot debug only 1 worker, or run the build in a single job separate of the host, without running 2 or more workers. This negative impact of this PR when compared to the positive seems acceptable, also it diverges from |
stefanpenner
force-pushed
the
respect-jobs
branch
2 times, most recently
from
20292a2
to
e8b793f
Compare
|
@ef4 pingaling |
For web-pack: JOBS=0 uses the current thread of execution JOBS=1..n spawns the corresponding thread or sub-processes No set JOBS results in a dynamically calculated number of jobs Previously JOBS=1 used the current thread of execution All other variations would dynamically calculated number of jobs
stefanpenner
force-pushed
the
respect-jobs
branch
from
e8b793f
to
0e4c1a8
Compare
|
In an offline chat with @ef4 around the authoring of this PR he gave a +1. If that has changed, I will gladly revert + fix. But no need to let this linger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For web-pack:
JOBS=0 uses the current thread of execution
JOBS=1..n spawns the corresponding thread or sub-processes
No set JOBS results in a dynamically calculated number of jobs
Previously
JOBS=1 used the current thread of execution
All other variations would dynamically calculated number of jobs