Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] Respect JOBS count if present #877

Merged
merged 1 commit into from
Aug 25, 2021
Merged

[BREAKING] Respect JOBS count if present #877

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/webpack/src/ember-webpack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,7 @@ const Webpack: PackagerConstructor<Options> = class Webpack implements Packager
};

const threadLoaderOptions = {
workers: 'JOBS' in process.env && Number(process.env.JOBS),
// poolTimeout shuts down idle workers. The problem is, for
// interactive rebuilds that means your startup cost for the
// next rebuild is at least 600ms worse. So we insist on
Expand All @@ -531,7 +532,7 @@ const threadLoaderOptions = {

function warmUp(extraOptions: object | false | undefined) {
// We don't know if we'll be parallel-safe or not, but if the environment sets
// JOBS to 1, or our extraOptions are set to false, we know we won't use
// JOBS to 0, or our extraOptions are set to false, we know we won't use
// thread-loader, so no need to consume extra resources warming the worker
// pool
if (process.env.JOBS === '1' || extraOptions === false) {
Expand All @@ -545,7 +546,7 @@ function warmUp(extraOptions: object | false | undefined) {
}

function maybeThreadLoader(isParallelSafe: boolean, extraOptions: object | false | undefined) {
if (process.env.JOBS === '1' || extraOptions === false || !isParallelSafe) {
if (process.env.JOBS === '0' || extraOptions === false || !isParallelSafe) {
return null;
}

Expand Down