Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Windows fixes with Windows CI #744

Closed
wants to merge 8 commits into from
Closed

Conversation

rwjblue
Copy link
Collaborator

@rwjblue rwjblue commented Mar 26, 2021

Merge #742 and #739 together, and test.

thoov and others added 5 commits March 25, 2021 20:30
Fixes: #681 & #676

Ember-cli's test suite caught an issue with windows support when
trying to enable embroider by default
(ember-cli/ember-cli#9495). After this change
I was able to successfully do a build with a new Ember app.
@thoov thoov mentioned this pull request Mar 26, 2021
@thoov
Copy link
Collaborator

thoov commented Apr 2, 2021

Closing as #752 supersedes this

@thoov thoov closed this Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants