Windows CI matrix #752
Merged
Windows CI matrix #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoov
commented
Apr 2, 2021
| @@ -1271,8 +1271,9 @@ export class AppBuilder<TreeNames> { | |||
| } | |||
|
|
|||
| let runtime = join(packageName, name).replace(this.resolvableExtensionsPattern, ''); | |||
| if (renamedModules && renamedModules[runtime]) { | |||
| runtime = renamedModules[runtime]; | |||
| let runtimeRenameLookup = runtime.split('\\').join('/'); | |||
There was a problem hiding this comment.
runtime will look like: ember-source\ember\index because of the join.
renamedModules will contain items like:
{
...
'ember-source/ember/index': 'ember/index'
...which fails to do the lookup. This converts the lookup to be in the expected format. I didn't change the meta info format as I'm not sure the full ramifications of that but a longer term solution would be to look into that.
This was referenced Apr 2, 2021
rwjblue
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains the changes to get #739 passing under Windows.