Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on Windows #676

Closed
RobbieTheWagner opened this issue Feb 5, 2021 · 4 comments · Fixed by #742
Closed

Error on Windows #676

RobbieTheWagner opened this issue Feb 5, 2021 · 4 comments · Fixed by #742

Comments

@RobbieTheWagner
Copy link

I am unable to run ember s on Windows and get the following error:

Error: Cannot find module 'C:Users
wwagDocumentsGitHubswach
ode_modules@embroidercoresrc	emplate-compiler.js'
Require stack:
- $TMPDIR\embroider\af1fbb\_template_compiler_.js
- C:\Users\rwwag\Documents\GitHub\swach\node_modules\@embroider\hbs-loader\src\index.js
- C:\Users\rwwag\Documents\GitHub\swach\node_modules\loader-runner\lib\loadLoader.js
- C:\Users\rwwag\Documents\GitHub\swach\node_modules\loader-runner\lib\LoaderRunner.js
- C:\Users\rwwag\Documents\GitHub\swach\node_modules\webpack\lib\NormalModule.js
- C:\Users\rwwag\Documents\GitHub\swach\node_modules\webpack\lib\NormalModuleFactory.js
- C:\Users\rwwag\Documents\GitHub\swach\node_modules\webpack\lib\Compiler.js
- C:\Users\rwwag\Documents\GitHub\swach\node_modules\webpack\lib\webpack.js
- C:\Users\rwwag\Documents\GitHub\swach\node_modules\ember-auto-import\js\webpack.js
- C:\Users\rwwag\Documents\GitHub\swach\node_modules\ember-auto-import\js\bundler.js
- C:\Users\rwwag\Documents\GitHub\swach\node_modules\ember-auto-import\js\auto-import.js
- C:\Users\rwwag\Documents\GitHub\swach\node_modules\ember-auto-import\js\index.js
- C:\Users\rwwag\Documents\GitHub\swach\node_modules\ember-cli\lib\models\package-info-cache\package-info.js
- C:\Users\rwwag\Documents\GitHub\swach\node_modules\ember-cli\lib\models\package-info-cache\index.js
- C:\Users\rwwag\Documents\GitHub\swach\node_modules\ember-cli\lib\models\project.js
- C:\Users\rwwag\Documents\GitHub\swach\node_modules\ember-cli\lib\utilities\get-config.js
- C:\Users\rwwag\Documents\GitHub\swach\node_modules\ember-cli\lib\utilities\instrumentation.js
- C:\Users\rwwag\Documents\GitHub\swach\node_modules\ember-cli\lib\cli\index.js
- C:\Users\rwwag\AppData\Roaming\npm\node_modules\ember-cli\bin\ember
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
    at Function.Module._load (internal/modules/cjs/loader.js:725:27)
    at Module.require (internal/modules/cjs/loader.js:952:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> ($TMPDIR\embroider\af1fbb\_template_compiler_.js:1:30)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Module.require (internal/modules/cjs/loader.js:952:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.hbsLoader (C:\Users\rwwag\Documents\GitHub\swach\node_modules\@embroider\hbs-loader\src\index.ts:14:66)
  - stack: ModuleBuildError: Module build failed (from C:/Users/rwwag/Documents/GitHub/swach/node_modules/@embroider/hbs-loader/src/index.js):

Any ideas how to fix this?

@RobbieTheWagner
Copy link
Author

It seems like something needs to be updated to handle Windows paths maybe?

@lifeart
Copy link
Collaborator

lifeart commented Feb 5, 2021

looks like issue in templateCompilerFile
resolved here:

templateCompilerFile: join(this.pathToVanillaApp, templateCompiler.filename),

@RobbieTheWagner
Copy link
Author

@lifeart are you saying this should be fixed already? How would I test out the fix?

@RobbieTheWagner
Copy link
Author

It looks like the latest is already released, so I guess this is still broken?

thoov added a commit to thoov/embroider that referenced this issue Mar 26, 2021
Fixes: embroider-build#681 & embroider-build#676

Ember-cli's test suite caught an issue with windows support when
trying to enable embroider by default
(ember-cli/ember-cli#9495). After this change
I was able to successfully do a build with a new Ember app.
@rwjblue rwjblue linked a pull request Mar 26, 2021 that will close this issue
rwjblue pushed a commit to thoov/embroider that referenced this issue Mar 29, 2021
Fixes: embroider-build#681 & embroider-build#676

Ember-cli's test suite caught an issue with windows support when
trying to enable embroider by default
(ember-cli/ember-cli#9495). After this change
I was able to successfully do a build with a new Ember app.
thoov added a commit to thoov/embroider that referenced this issue Mar 29, 2021
Fixes: embroider-build#681 & embroider-build#676

Ember-cli's test suite caught an issue with windows support when
trying to enable embroider by default
(ember-cli/ember-cli#9495). After this change
I was able to successfully do a build with a new Ember app.
@ef4 ef4 closed this as completed in #742 Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants